Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] unit test code coverage visible on Codecov.io #54

Open
tisnik opened this issue Oct 16, 2024 · 2 comments · May be fixed by #69
Open

[RFE] unit test code coverage visible on Codecov.io #54

tisnik opened this issue Oct 16, 2024 · 2 comments · May be fixed by #69
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tisnik
Copy link
Collaborator

tisnik commented Oct 16, 2024

Unit test code coverage should visible on Codecov.io. We have the job to run unit tests, so it needs to be modified to publish results on Codecov.io.

@tisnik tisnik added enhancement New feature or request good first issue Good for newcomers labels Oct 16, 2024
@r0x0d
Copy link
Contributor

r0x0d commented Oct 21, 2024

We used to use codecov.io on https://github.com/oamg/convert2rhel, and there we had a problem that at some point, codecov started to ask us to authenticate with a token to keep publishing results there.

If I'm not wrong, submitting results without token only allowed you to push a couple of requests. That was a major problem because we were working on a fork-based strategy in that repo, which means that we couldn't expose the token in GitHub actions for forks (at least, not without making the pipeline unsecure)


With that said, probably things have changed from that time to now, but in any case, it is good to investigate if that is still happening.

andywaltlova added a commit to andywaltlova/service that referenced this issue Oct 22, 2024
@andywaltlova andywaltlova linked a pull request Oct 22, 2024 that will close this issue
5 tasks
@andywaltlova
Copy link

I wanted to take the issue, but it is indeed true, token is required for protected branches (according to this https://docs.codecov.com/docs/codecov-tokens ) and since https://github.com/road-core/service/blob/main/CONTRIBUTING.md#tldr suggests to use fork most probably condition is needed, I did try it in #69 but since I don't have access I need approval to run the workflows and see if it works (not really great for testing). I can leave the issue to someone else to finish if I can't have the access :)

andywaltlova added a commit to andywaltlova/service that referenced this issue Oct 22, 2024
andywaltlova added a commit to andywaltlova/service that referenced this issue Oct 31, 2024
With codecov v4+ forks are detected automatically and tokenless upload
is used

Signed-off-by: Andrea Waltlova <[email protected]>

Signed-off-by: Andrea Waltlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants