From 6deb52c14eb2cc9514074879e292c151f4a83285 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?JimmyLv=5F=E5=90=95=E7=AB=8B=E9=9D=92?= Date: Sat, 30 Apr 2022 16:42:53 +0800 Subject: [PATCH 1/6] fix: add embedPageTitle selector for adding click hint to the embed page title #216 --- src/ts/core/features/vim-mode/hint-view.ts | 2 +- src/ts/core/roam/selectors.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ts/core/features/vim-mode/hint-view.ts b/src/ts/core/features/vim-mode/hint-view.ts index 31253461..f0698aa6 100644 --- a/src/ts/core/features/vim-mode/hint-view.ts +++ b/src/ts/core/features/vim-mode/hint-view.ts @@ -51,7 +51,7 @@ Promise.all(HINT_IDS.map(hintCss)).then(cssClasses => { export const updateVimHints = (block: HTMLElement) => { // button is for reference counts const links = block.querySelectorAll( - `${Selectors.link}, ${Selectors.externalLink}, ${Selectors.checkbox}, ${Selectors.button}, ${Selectors.blockReference}` + `${Selectors.link}, ${Selectors.externalLink}, ${Selectors.embedPageTitle}, ${Selectors.checkbox}, ${Selectors.button}, ${Selectors.blockReference}` ) links.forEach((link, i) => { link.classList.add(HINT_CSS_CLASS, hintCssClass(i)) diff --git a/src/ts/core/roam/selectors.ts b/src/ts/core/roam/selectors.ts index 78b6f0bc..51cc09a2 100644 --- a/src/ts/core/roam/selectors.ts +++ b/src/ts/core/roam/selectors.ts @@ -27,7 +27,8 @@ export const Selectors = { dailyNotes: '#rm-log-container', viewMore: '.roam-log-preview', checkbox: '.check-container', - externalLink: 'a', + externalLink: 'a[target="_blank"]', + embedPageTitle: '.rm-embed--page a span.rm-page__title', referenceItem: '.rm-reference-item', breadcrumbsContainer: '.zoom-mentions-view', pageReferenceItem: '.rm-ref-page-view', From 10cbee225050aba3a702e62109349cca7c491ca1 Mon Sep 17 00:00:00 2001 From: JimmyLv Date: Sat, 14 May 2022 10:30:47 +0800 Subject: [PATCH 2/6] fix: update more accurate selector for a --- src/ts/core/roam/selectors.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ts/core/roam/selectors.ts b/src/ts/core/roam/selectors.ts index 03d00dba..d773d6b1 100644 --- a/src/ts/core/roam/selectors.ts +++ b/src/ts/core/roam/selectors.ts @@ -28,7 +28,7 @@ export const Selectors = { dailyNotes: '#rm-log-container', viewMore: '.roam-log-preview', checkbox: '.check-container', - externalLink: 'a[target="_blank"]', + externalLink: 'a.rm-alias', embedPageTitle: '.rm-embed--page a span.rm-page__title', referenceItem: '.rm-reference-item', breadcrumbsContainer: '.zoom-mentions-view', From 1ccdb664044a17a396b9542036c5a759831148ff Mon Sep 17 00:00:00 2001 From: JimmyLv Date: Mon, 16 May 2022 19:19:01 +0800 Subject: [PATCH 3/6] fix: support click a link under vim mode --- src/ts/core/features/vim-mode/hint-view.ts | 1 + src/ts/core/roam/selectors.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/ts/core/features/vim-mode/hint-view.ts b/src/ts/core/features/vim-mode/hint-view.ts index 5be51f80..2428a8a6 100644 --- a/src/ts/core/features/vim-mode/hint-view.ts +++ b/src/ts/core/features/vim-mode/hint-view.ts @@ -53,6 +53,7 @@ export const updateVimHints = (block: HTMLElement) => { const clickableSelectors = [ Selectors.link, Selectors.externalLink, + Selectors.linkInBlockRef, Selectors.embedPageTitle, Selectors.checkbox, Selectors.button, diff --git a/src/ts/core/roam/selectors.ts b/src/ts/core/roam/selectors.ts index d773d6b1..72b0417c 100644 --- a/src/ts/core/roam/selectors.ts +++ b/src/ts/core/roam/selectors.ts @@ -29,6 +29,7 @@ export const Selectors = { viewMore: '.roam-log-preview', checkbox: '.check-container', externalLink: 'a.rm-alias', + linkInBlockRef: '.rm-block-ref a[target="_blank"]', embedPageTitle: '.rm-embed--page a span.rm-page__title', referenceItem: '.rm-reference-item', breadcrumbsContainer: '.zoom-mentions-view', From e343c9bb34c7aefcab596a3ea906314ace833f0a Mon Sep 17 00:00:00 2001 From: JimmyLv Date: Mon, 16 May 2022 20:09:43 +0800 Subject: [PATCH 4/6] fix: update link for element --- src/ts/core/roam/selectors.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ts/core/roam/selectors.ts b/src/ts/core/roam/selectors.ts index 72b0417c..52df244f 100644 --- a/src/ts/core/roam/selectors.ts +++ b/src/ts/core/roam/selectors.ts @@ -28,7 +28,7 @@ export const Selectors = { dailyNotes: '#rm-log-container', viewMore: '.roam-log-preview', checkbox: '.check-container', - externalLink: 'a.rm-alias', + externalLink: 'a.rm-alias, a[target="_blank"]', linkInBlockRef: '.rm-block-ref a[target="_blank"]', embedPageTitle: '.rm-embed--page a span.rm-page__title', referenceItem: '.rm-reference-item', From d092eb26b0e83d892544f826090d20451c412498 Mon Sep 17 00:00:00 2001 From: JimmyLv Date: Thu, 18 May 2023 14:28:37 +0800 Subject: [PATCH 5/6] feat: support functionalRef button --- src/ts/core/roam/selectors.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ts/core/roam/selectors.ts b/src/ts/core/roam/selectors.ts index 52df244f..d4903004 100644 --- a/src/ts/core/roam/selectors.ts +++ b/src/ts/core/roam/selectors.ts @@ -31,6 +31,7 @@ export const Selectors = { externalLink: 'a.rm-alias, a[target="_blank"]', linkInBlockRef: '.rm-block-ref a[target="_blank"]', embedPageTitle: '.rm-embed--page a span.rm-page__title', + functionalRef: '.rm-video-timestamp, button', referenceItem: '.rm-reference-item', breadcrumbsContainer: '.zoom-mentions-view', pageReferenceItem: '.rm-ref-page-view', From f072e3b8ab7bffed114ec91056d1976e8a526bc3 Mon Sep 17 00:00:00 2001 From: JimmyLv Date: Thu, 18 May 2023 14:29:12 +0800 Subject: [PATCH 6/6] fix: add into selectors --- src/ts/core/features/vim-mode/hint-view.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ts/core/features/vim-mode/hint-view.ts b/src/ts/core/features/vim-mode/hint-view.ts index 2428a8a6..2b0bdcd9 100644 --- a/src/ts/core/features/vim-mode/hint-view.ts +++ b/src/ts/core/features/vim-mode/hint-view.ts @@ -54,6 +54,7 @@ export const updateVimHints = (block: HTMLElement) => { Selectors.link, Selectors.externalLink, Selectors.linkInBlockRef, + Selectors.functionalRef, Selectors.embedPageTitle, Selectors.checkbox, Selectors.button,