-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example for Generic Concrete Ultimate Profile in materials.rst #83
Comments
Hi @Agent6-6-6, this example is inconsistent, the compressive strength should be modified As far as I'm aware, no other modules access the I believe the The Does this answer the question? |
Hi @robbievanleeuwen, hopefully, the following makes sense! In the I guess what is required to populate these variables so they can be accessed is to simply run these
As it stands for some of the profiles if I'm interpreting it correctly the Also for the EC2 profiles that are being worked on in #80, they will have to work in a similar way populating the values at the end because there is no input The idea is if I have not already done it would be to populate this value at the end of the generation of the profile so it can be returned and isn't equal to I have always been interpreting the |
Hi @robbievanleeuwen
In going through implementing #80, I've noted the following doesn't seem consistent in the numbers utilised.
The example in
material.rst
implies a variable youngs modulus E for the strain calculations, and stresses provided max out at 40MPa but compressive strength is defined as only 32 MPa so inputs don't seem consistent with one another. Maybe I'm missing something here though, but it seems like this needs to be modified to a constant E consistent with the specified compressive strength and the maximum compressive strength and max stress aligned so they are the same value?I think this is a case where
ultimate_strain
(don't think this is even initiated for this generic profile or parent class which would presumably cause some issues if it was used for a design_code check) and possiblycompressive_strength
should possibly just be populated from the user input at the end of the__post_init__
method and not initiatecompressive_strength
as an input:-i.e.
self.ultimate_strain = max(self.strains)
, and similar for theconcrete_strength
variable.The text was updated successfully, but these errors were encountered: