-
Notifications
You must be signed in to change notification settings - Fork 57
Description
In going through implementing #80, I've noted the following doesn't seem consistent in the numbers utilised.
The example in material.rst
implies a variable youngs modulus E for the strain calculations, and stresses provided max out at 40MPa but compressive strength is defined as only 32 MPa so inputs don't seem consistent with one another. Maybe I'm missing something here though, but it seems like this needs to be modified to a constant E consistent with the specified compressive strength and the maximum compressive strength and max stress aligned so they are the same value?
from concreteproperties.stress_strain_profile import ConcreteUltimateProfile
ConcreteUltimateProfile(
strains=[-20 / 30e3, 0, 20 / 30e3, 30 / 25e3, 40 / 20e3, 0.003],
stresses=[0, 0, 20, 30, 40, 40],
compressive_strength=32,
).plot_stress_strain()
I think this is a case where ultimate_strain
(don't think this is even initiated for this generic profile or parent class which would presumably cause some issues if it was used for a design_code check) and possibly compressive_strength
should possibly just be populated from the user input at the end of the __post_init__
method and not initiate compressive_strength
as an input:-
i.e. self.ultimate_strain = max(self.strains)
, and similar for the concrete_strength
variable.