Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant Rhs() call inefficiency via non-cacheing of symbolMapClass lookups #121

Open
robclewley opened this issue Nov 24, 2016 · 0 comments
Labels

Comments

@robclewley
Copy link
Owner

parseUtils.py symbolMapClass does not cache results when it uses parserObject to check unrecognized string inputs. It could update lookupDict with its result for much greater efficiency if being called repeatedly with the same unrecognized arguments. A use case of PyCont has indicated that continuation can be many times slower in v0.90 than it should be because of the overhead of always remapping parameter and variable name arguments through FScompatibleNames lookup during Rhs() calls.

This approach has the drawback of potentially growing the size of the dictionary without bound if repeatedly called with unique inputs. Ideally, the parameter and variable names should already be mapped by default using the identity mapping in FScompatibleNames if they don't use hierarchical '.' notation.

@robclewley robclewley added the bug label Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant