Refactor configuration editing logic into shared helper functions

Author: robertpiosik

packages/vscode/package.json

@@ -2,7 +2,7 @@
   "name": "gemini-coder",
   "displayName": "Code Web Chat",
   "description": "CWC connects VS Code with ChatGPT, Gemini, Claude, and 10+ more",
-  "version": "1.369.0",
+  "version": "1.370.0",
   "scripts": {
     "build": "npx vsce package --no-dependencies",
     "vscode:prepublish": "rimraf out && npm run compile",

packages/vscode/src/commands/code-completion-commands.ts

@@ -59,7 +59,7 @@ const get_code_completion_config = async (
   config_index?: number,
   view_provider?: ViewProvider
 ): Promise<{ provider: any; config: any } | undefined> => {
-  let code_completions_configs =
+  const code_completions_configs =
     await api_providers_manager.get_code_completions_tool_configs()
 
   if (code_completions_configs.length == 0) {

packages/vscode/src/views/settings/backend/message-handlers/config-editing-helpers.ts

@@ -0,0 +1,263 @@
+import * as vscode from 'vscode'
+import {
+  ApiProvidersManager,
+  Provider,
+  ToolConfig
+} from '@/services/api-providers-manager'
+import {
+  ModelFetcher,
+  MODELS_ROUTE_NOT_FOUND_ERROR
+} from '@/services/model-fetcher'
+import { PROVIDERS } from '@shared/constants/providers'
+import { Logger } from '@shared/utils/logger'
+
+export const initial_select_provider = async (
+  providers_manager: ApiProvidersManager
+): Promise<Provider | undefined> => {
+  const providers = await providers_manager.get_providers()
+
+  if (providers.length === 0) {
+    vscode.window.showWarningMessage(
+      'No API providers configured. Please add an API provider first on the "API Providers" page.'
+    )
+    return
+  }
+
+  const provider_items = providers.map((p) => ({ label: p.name, provider: p }))
+  const selected = await vscode.window.showQuickPick(provider_items, {
+    title: 'Select a Provider'
+  })
+
+  return selected?.provider
+}
+
+export const initial_select_model = async (
+  model_fetcher: ModelFetcher,
+  provider: Provider
+): Promise<string | undefined> => {
+  try {
+    const base_url =
+      provider.type == 'built-in'
+        ? PROVIDERS[provider.name]?.base_url
+        : provider.base_url
+    if (!base_url)
+      throw new Error(`Base URL not found for provider ${provider.name}`)
+
+    const models = await model_fetcher.get_models({
+      base_url,
+      api_key: provider.api_key
+    })
+
+    if (models.length > 0) {
+      const model_items = models.map((model) => ({
+        label: model.name || model.id,
+        description: model.name ? model.id : undefined,
+        detail: model.description
+      }))
+      const selected = await vscode.window.showQuickPick(model_items, {
+        title: 'Select Model',
+        placeHolder: 'Choose an AI model'
+      })
+      if (selected) return selected.description || selected.label
+      return // User cancelled
+    }
+  } catch (error) {
+    Logger.error({
+      function_name: 'initial_select_model',
+      message: 'Failed to fetch models',
+      data: error
+    })
+    if (
+      error instanceof Error &&
+      error.message == MODELS_ROUTE_NOT_FOUND_ERROR
+    ) {
+      vscode.window.showInformationMessage(
+        `The '/models' route was not found for ${provider.name}. This might mean the provider does not support listing models.`
+      )
+    } else {
+      vscode.window.showErrorMessage(
+        `Failed to fetch models: ${
+          error instanceof Error ? error.message : String(error)
+        }`
+      )
+    }
+  }
+
+  return await vscode.window.showInputBox({
+    title: 'Enter Model Name',
+    prompt: 'Could not fetch models. Please enter a model name (ID).'
+  })
+}
+
+export const edit_provider_for_config = async (
+  providers_manager: ApiProvidersManager
+) => {
+  const providers = await providers_manager.get_providers()
+  const provider_items = providers.map((p) => ({
+    label: p.name,
+    detail: p.type,
+    provider: p
+  }))
+  const selected_provider_item = await vscode.window.showQuickPick(
+    provider_items,
+    { title: 'Select a Provider' }
+  )
+  if (selected_provider_item) {
+    return {
+      provider_name: selected_provider_item.provider.name,
+      provider_type: selected_provider_item.provider.type
+    }
+  }
+  return undefined
+}
+
+export const edit_model_for_config = async (
+  config: ToolConfig,
+  providers_manager: ApiProvidersManager,
+  model_fetcher: ModelFetcher
+) => {
+  const provider_from_manager = await providers_manager.get_provider(
+    config.provider_name
+  )
+  if (!provider_from_manager) {
+    vscode.window.showErrorMessage(
+      `Provider ${config.provider_name} not found.`
+    )
+    return undefined
+  }
+
+  const base_url =
+    provider_from_manager.type == 'built-in'
+      ? PROVIDERS[provider_from_manager.name]?.base_url
+      : provider_from_manager.base_url
+
+  if (!base_url) {
+    vscode.window.showErrorMessage(
+      `Base URL not found for provider ${config.provider_name}.`
+    )
+    return undefined
+  }
+
+  let new_model_value: string | undefined
+  let model_selected = false
+
+  try {
+    const models = await model_fetcher.get_models({
+      base_url,
+      api_key: provider_from_manager.api_key
+    })
+
+    if (models.length > 0) {
+      const model_items = models.map((model) => ({
+        label: model.name || model.id,
+        description: model.name ? model.id : undefined,
+        detail: model.description
+      }))
+      const selected_model_item = await vscode.window.showQuickPick(
+        model_items,
+        { title: 'Select Model', placeHolder: 'Choose an AI model' }
+      )
+      if (selected_model_item) {
+        new_model_value =
+          selected_model_item.description || selected_model_item.label
+        model_selected = true
+      }
+    } else {
+      vscode.window.showWarningMessage(
+        `No models found for ${config.provider_name}. You can enter model name manually.`
+      )
+    }
+  } catch (error) {
+    Logger.error({
+      function_name: 'edit_model_for_config',
+      message: 'Failed to fetch models',
+      data: error
+    })
+    if (
+      error instanceof Error &&
+      error.message == MODELS_ROUTE_NOT_FOUND_ERROR
+    ) {
+      vscode.window.showInformationMessage(
+        `The '/models' route was not found for ${config.provider_name}. This might mean the provider does not support listing models. You can enter model name manually.`
+      )
+    } else {
+      vscode.window.showErrorMessage(
+        `Failed to fetch models: ${
+          error instanceof Error ? error.message : String(error)
+        }`
+      )
+    }
+  }
+
+  if (!model_selected) {
+    const new_model_input = await vscode.window.showInputBox({
+      title: 'Enter Model Name',
+      value: config.model,
+      prompt: `Enter a model name (ID)`
+    })
+    if (new_model_input !== undefined) new_model_value = new_model_input
+  }
+
+  if (new_model_value !== undefined) return new_model_value.trim()
+  return undefined
+}
+
+export const edit_temperature_for_config = async (config: ToolConfig) => {
+  const new_temp_str = await vscode.window.showInputBox({
+    title: 'Edit Temperature',
+    value: String(config.temperature),
+    prompt: 'Enter a value between 0 and 2',
+    validateInput: (value) => {
+      const num = parseFloat(value)
+      if (isNaN(num) || num < 0 || num > 2) {
+        return 'Please enter a number between 0 and 2.'
+      }
+      return null
+    }
+  })
+  if (new_temp_str !== undefined) return parseFloat(new_temp_str)
+  return undefined
+}
+
+export const edit_reasoning_effort_for_config = async () => {
+  const effort_options: ('auto' | 'low' | 'medium' | 'high')[] = [
+    'auto',
+    'low',
+    'medium',
+    'high'
+  ]
+  const selected_effort = await vscode.window.showQuickPick(effort_options, {
+    title: 'Select Reasoning Effort'
+  })
+  return selected_effort
+}
+
+export const edit_instructions_placement_for_config = async () => {
+  const placement_options: ('above-and-below' | 'below-only')[] = [
+    'above-and-below',
+    'below-only'
+  ]
+  const selected_placement = await vscode.window.showQuickPick(
+    placement_options,
+    { title: 'Select Instructions Placement' }
+  )
+  return selected_placement
+}
+
+export const edit_max_concurrency_for_config = async (config: ToolConfig) => {
+  const new_concurrency_str = await vscode.window.showInputBox({
+    title: 'Edit Max Concurrency',
+    value: String(config.max_concurrency ?? 1),
+    prompt: 'Enter a number for max concurrency',
+    validateInput: (value) => {
+      const num = parseInt(value, 10)
+      if (isNaN(num) || !Number.isInteger(num) || num < 1) {
+        return 'Please enter a whole number greater than or equal to 1.'
+      }
+      return null
+    }
+  })
+  if (new_concurrency_str !== undefined)
+    return parseInt(new_concurrency_str, 10)
+  return undefined
+}