Consisting of stylistic (favoring pre-increment over post-) and comment / typo changes, this is inching closer to being the FINAL commit for the "old-style" (aka "V2") version of RMs.

Author: robertroessler

RMsCore.cpp

@@ -357,11 +357,11 @@ void rms_publish_string(std::string_view tag, std::string_view data) noexcept(fa
 	dumpExported("rms_publish_string('{}','{:.8}...')...()\n", tag, data);
 	if (tag.empty())
 		return;	// we're OUTTA here!
-	// N.B. - limit any data to 0 <= strlen(data) <= 4095!
+	// N.B. - limit any data to 0 <= strlen(data) <= 4096!
 	if (data.size() > 4096)
 		throw invalid_argument(string("rms_publish_string passed invalid length ") + to_string(data.size()));
 	dumpExported("rms_publish_string('{}'...)...Distribute()\n", tag);
-	rmsRoot->Distribute(tag, data.data(), (int)data.size());
+	rmsRoot->Distribute(tag, data.data(), data.size());
 }
 
 RMS_EXPORT
@@ -609,7 +609,7 @@ int RMsRoot::CheckQueue(int pg) const
 		lock_guard<rms::RSpinLockEx> acquire(remove_const_t<rms::RSpinLockEx>(spin));
 		for (auto q = queueHead; q; q = ((RMsQueue*)pg2xp(q))->next)
 			if (q == pg)
-				n++;
+				++n;
 		if (!n)
 			dumpCheck("RMsRoot::CheckQueue({})... is BOGUS (NOT found)\n", pg);
 		else if (n > 1)
@@ -738,7 +738,7 @@ RMsQueue::~RMsQueue()
 	rmsRoot->RemoveQueue(pg);
 	Flush();
 	dumpQueue("<{}>::~RMsQueue()...freeing {} indirect pages\n", pg, remove_volatile_t<int>(pages));
-	for (auto i = 0; i < pages; i++)
+	for (auto i = 0; i < pages; ++i)
 		rmsRoot->FreePage(pageE[i]);
 	rmsRoot->FreeRP(pattern);
 	rmsRoot->FreePage(pg);
@@ -792,7 +792,7 @@ void RMsQueue::append(rms_ptr_t tag, rms_ptr_t data)
 		return rmsRoot->FreePair(td);	// early out; "signaled"
 	if (const auto [status, pg, pi] = checkWrite(); status)
 		(write < NQuick ? quickE[write] : ((pq_pag_t*)pg2xp(pg))->pqTD[pi]) = td,
-			write++, semaphore.signal();
+			++write, semaphore.signal();
 	else
 		rmsRoot->FreePair(td);
 	dumpQueue("<{}>::append({:x}:{:x})...{}\n", xp2pg(this), tag, data, remove_volatile_t<int>(write));
@@ -867,7 +867,7 @@ void RMsQueue::Flush()
 	while (read < write)
 		rmsRoot->FreePair(read < NQuick ?
 			quickE[read] :
-			((pq_pag_t*)pg2xp(pageE[qp2pq(read)]))->pqTD[qp2pi(read)]), read++;
+			((pq_pag_t*)pg2xp(pageE[qp2pq(read)]))->pqTD[qp2pi(read)]), ++read;
 	read = 0, write = 0, state = 0;
 }
 

rms.h

@@ -507,7 +507,7 @@ void initialize(int np);
 class publisher {
 public:
 	// publish "tag/data pair" to any subscription queues with matching patterns
-	static void put_with_tag(std::string_view d, std::string_view t) { rms_publish_bytes(t, (const unsigned char*)d.data(), (int)d.size()); }
+	static void put_with_tag(std::string_view d, std::string_view t) { rms_publish_string(t, d); }
 	static void put_with_tag(const unsigned char* d, size_t n, std::string_view t) { rms_publish_bytes(t, d, n); }
 	static void put_with_tag(rms_ieee d, std::string_view t) { rms_publish_ieee(t, d); }
 	static void put_with_tag(rms_int32 d, std::string_view t) { rms_publish_int32(t, d); }

t1.cpp

@@ -78,6 +78,6 @@ int main(int argc, char* argv[])
 	const auto t1 = high_resolution_clock::now();
 	rms_close(id);
 	printf("timing for %d Publish/Wait pairs = %g ns/round-trip\n", Iterations * Transactions,
-		(duration_cast<microseconds>(t1 - t0).count() / (double(Iterations) * Transactions / 1000)));
+		(duration_cast<nanoseconds>(t1 - t0).count() / (double(Iterations) * Transactions)));
 	return 0;
 }

t2.cpp

@@ -61,6 +61,6 @@ int main(int argc, char* argv[])
 	}
 	const auto t1 = high_resolution_clock::now();
 	cout << "timing for " << Iterations * Transactions << " Publish/Wait pairs = "
-		<< (duration_cast<microseconds>(t1 - t0).count() / (double(Iterations) * Transactions / 1000)) << " ns/round-trip" << endl;
+		<< (duration_cast<nanoseconds>(t1 - t0).count() / (double(Iterations) * Transactions)) << " ns/round-trip" << endl;
 	return 0;
 }

t3.cpp

@@ -64,7 +64,7 @@ int main(int argc, char* argv[])
 	}
 	const auto t1 = high_resolution_clock::now();
 	cout << "timing for " << Iterations * Transactions << " Publish/Wait pairs = "
-		<< (duration_cast<microseconds>(t1 - t0).count() / (double(Iterations) * Transactions / 1000)) << " ns/round-trip" << endl;
+		<< (duration_cast<nanoseconds>(t1 - t0).count() / (double(Iterations) * Transactions)) << " ns/round-trip" << endl;
 	// now for some exciting multi-threaded tests...
 	// ... first, create a thread watching our queue
 	std::thread t([&]() {