Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks great! Here are a few findings. #1

Open
haxoza opened this issue Dec 18, 2023 · 0 comments
Open

Looks great! Here are a few findings. #1

haxoza opened this issue Dec 18, 2023 · 0 comments

Comments

@haxoza
Copy link

haxoza commented Dec 18, 2023

Hi, just playing and reviewing the code and overall idea. Looks really promissing!

Please find a few findings noted when I went through the code.

apps.populate(settings.INSTALLED_APPS)

Shouldn't it use django.setup() method?

fadin/fadin/app/asgi.py

Lines 52 to 53 in ae8105e

request.state.session = session if user.is_authenticated else None
request.state.user = user if user.is_authenticated else None

Why not just passing the actual session object and AnonymousUser instance to fastapi? E.g. like

request.state.session = session
request.state.user = user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant