type/sfml: Disregard fonts that can't render ASCII #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0-One
approved these changes
Nov 19, 2024
This moves the hack from a447a4f one level down, so we now drop these fonts before they reach the gfx system. This fixes an issue where we could end up measuring text with a font that would later be dropped by the gfx system, leading to a relayout being needed for the rendering to look correct.
robinlinden
force-pushed
the
type-sfml-font-selection
branch
from
3031ebb
to
17b90b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
("Noto" was resolved to "Noto Kufi Arabic" which doesn't have an 'A' glyph.)