update to 1.0.19, removed headers #27
Conversation
There was a problem hiding this comment.
Neat, thank you! And I'm happy you found the project useful! :D
The only real comment is that I'd like for each commit to be in a working state, so maybe commit 1: remove headers, commit 2: update to 1.0.19, but if you'd like I can rebase and restructure the commits for you. :P
Seems like the MSVC CI is also failing due to unresolved symbols. I guess you ran this on Linux? Need any help looking into those failures or is it something you can dig into for a bit?
|
sure! thats something i can get started on tomorrow, and yeah you called it I wrote it while on linux haha feel free to restructure it yourself if I don't get to it, thanks! |
|
looks like MSVC will need a bit more work, still looking into it haha |
|
No rush! Let me know if you hit a wall with it and I can take a look. :P |
|
currently hit a wall haha, some things I've tried doing (although might just be spinning my wheels):
let me know if you have any other ideas or if you can check as well, thank you! |
| @@ -147,12 +137,13 @@ target_compile_definitions(${PROJECT_NAME} | |||
| $<$<BOOL:${SODIUM_ENABLE_BLOCKING_RANDOM}>:USE_BLOCKING_RANDOM> | |||
| $<$<BOOL:${SODIUM_MINIMAL}>:MINIMAL> | |||
| $<$<C_COMPILER_ID:MSVC>:_CRT_SECURE_NO_WARNINGS> | |||
| $<$<C_COMPILER_ID:MSVC>:> | |||
There was a problem hiding this comment.
this was committed by mistake, i'll be sure to remove this in the final working commit
closes #5 and #26
been using your project for a while now, thank you!
let me know if you need any changes