Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to run latest when fileName is not release.tar.gz #601

Open
i-am-the-slime opened this issue Feb 15, 2023 · 5 comments
Open

Failing to run latest when fileName is not release.tar.gz #601

i-am-the-slime opened this issue Feb 15, 2023 · 5 comments
Labels
question Further information is requested

Comments

@i-am-the-slime
Copy link

Describe the bug
I have a monorepo and just added another workflow for a different app. I made sure to tag its releases as ai-annotator-release.tar.gz.

To Reproduce
This are the two steps in question. The first one only runs when input is not latest and it works. The second one is copy pasted and does not work. In another action the same thing does work and the only difference I can see is that:

  • I have fileName: "ai-annotator-release.tar.gz
    steps:
      # THIS STEP WORKS
      - name: Download specific release
        if: "${{ github.event.inputs.version != 'latest' }}"
        uses: robinraju/[email protected]
        with:
          repository: ${{ github.repository }}
          fileName: "ai-annotator-release.tar.gz"
          token: ${{ secrets.GITHUB_TOKEN }}
          tag: ${{ github.event.inputs.version }}

      - name: Download latest release
        # THIS STEP FAILS 
        if: "${{ github.event.inputs.version == 'latest' }}"
        uses: robinraju/[email protected]
        with:
          repository: ${{ github.repository }}
          fileName: "ai-annotator-release.tar.gz"
          token: ${{ secrets.GITHUB_TOKEN }}
          latest: true

Expected behavior
It should

Screenshots
image

Action Environment (please complete the following information):

  • OS: ubuntu-latest

Additional context
I'm not sure this is actually a bug or if I'm doing something wrong.

@robinraju
Copy link
Owner

Are you still facing this error? Can you check if your release is not marked as a pre-release/draft.

@robinraju robinraju added the question Further information is requested label Apr 28, 2023
@i-am-the-slime
Copy link
Author

i-am-the-slime commented May 2, 2023

Yes, this is still a problem. The lastest version does not respect the file name as far as I can tell:

It finds ai-annotator... as the latest release (which is true for the repository), but it should be the latest release for this particular name. I'm not sure that's even possible, to be honest.

Found latest release version: ai-annotator-2023-04-26|14-40
Error: Asset with name release.tar.gz not found!

It downloads the globally latest version (this is the step):

      - name: Download latest release
        if: "${{ github.event.inputs.version == 'latest-website' }}"
        uses: robinraju/[email protected]
        with:
          repository: ${{ github.repository }}
          fileName: "release.tar.gz"
          token: ${{ secrets.GITHUB_TOKEN }}
          latest: true

@robinraju
Copy link
Owner

please reopen, if this issue persists with the latest version

@i-am-the-slime
Copy link
Author

This still doesn't work for me. Not sure how to reopen.

@i-am-the-slime
Copy link
Author

@robinraju

@robinraju robinraju reopened this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants