Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demoapp listening address more wider, required to dockerized solution. #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chaggeus
Copy link

@chaggeus chaggeus commented Oct 7, 2020

Demoapp listening address chanced to more wider: localhost => 0.0.0.0
In docker container call come over ip so localhost not work.
Added dockerized solution of demoapp that benefit is that it goes backround automaticly.

@aaltat
Copy link
Contributor

aaltat commented Oct 19, 2020

Thank you for the PR.

This demo repo should be simple as possible and I agree that in most cases docker is good solution, in this repo it might leave people to wrong path. Therefore I am thinking that we should leave the docker out of this repository. But we can change the: HTTPServer.__init__(self, ('localhost', int(port)), to HTTPServer.__init__(self, ('0.0.0.0', int(port)), because that causes problems in docker usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants