Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to get and store parameters for configuring FilteringAlgorithm #33

Open
claudiofantacci opened this issue Mar 29, 2019 · 1 comment
Assignees

Comments

@claudiofantacci
Copy link
Collaborator

No description provided.

@claudiofantacci claudiofantacci added this to the 0.9.0 milestone May 6, 2019
@claudiofantacci claudiofantacci self-assigned this May 23, 2019
@claudiofantacci
Copy link
Collaborator Author

Implementation of this helper class committed in claudiofantacci@4bf9d01.
I'm not satisfied with it and I think I will make improvements before merging everything into master.

For example, I'm still thinking about whether keeping all the implicit conversion (useful to have simple instructions like int int_data = parameter_container["a label"]) or to replace them with explicit type cast (e.g. int int_data = parameter_container["a label"].as_int()). The second is more verbose but probably safer and transparent from the user perspective.
Also, conversions are currently not safe at runtime and throw when the required required type is not the one stored.

@xEnVrE xEnVrE removed this from the 0.9.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants