You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many classes have way too much protected data member that should probably be moved in private scope. See for example GaussianMixture and derived classes.
The current library rework is addressing this.
The main problem seems related to GaussianMixture and derived classes where we need to carefully think about the consequences of this change.
in SIS.h it becomes difficult to inherit from it (obviously, we don't have proper interfaces to those data). As a matter of fact, the user cannot access that data at all and this is no longer acceptable as they are the product of the class itself. I'm going to change this behavior.
@xEnVrE we need to discuss GaussianMixture f2f asap.
Many classes have way too much
protected
data member that should probably be moved inprivate
scope. See for exampleGaussianMixture
and derived classes.cc @xEnVrE
The text was updated successfully, but these errors were encountered: