From 49aab77439ce7e3edc4480bd03cb9f44cc3b2543 Mon Sep 17 00:00:00 2001
From: Hannes Mehnert <hannes@mehnert.org>
Date: Tue, 4 Feb 2025 15:21:01 +0100
Subject: [PATCH] albatrossd: on startup, back up state file, fixes #203

---
 daemon/albatrossd.ml |  5 +++++
 src/vmm_unix.ml      | 11 ++++++++++-
 src/vmm_unix.mli     |  2 ++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/daemon/albatrossd.ml b/daemon/albatrossd.ml
index 70d0f35..5f0650e 100644
--- a/daemon/albatrossd.ml
+++ b/daemon/albatrossd.ml
@@ -178,6 +178,11 @@ let jump _ systemd influx tmpdir dbdir =
   match Vmm_vmmd.restore_state () with
   | Error (`Msg msg) -> Logs.err (fun m -> m "bailing out: %s" msg)
   | Ok (old_unikernels, policies) ->
+    let file = "state.started" in
+    (match Vmm_unix.backup file with
+     | Ok () -> Logs.info (fun m -> m "backing up state to %s" file)
+     | Error `Msg msg -> Logs.err (fun m -> m "backing up state failed: %s" msg)
+     | Error `NoFile -> Logs.err (fun m -> m "backing up state failed - no file"));
     let policies, old_p = Vmm_trie.insert Name.root root_policy policies in
     Option.iter (fun p ->
         if not (Policy.equal p root_policy) then
diff --git a/src/vmm_unix.ml b/src/vmm_unix.ml
index 40701fb..9d4b9c6 100644
--- a/src/vmm_unix.ml
+++ b/src/vmm_unix.ml
@@ -108,7 +108,7 @@ let close_no_err fd = try close fd with _ -> ()
 (* own code starts here
    (c) 2017, 2018 Hannes Mehnert, all rights reserved *)
 
-let dump, restore =
+let dump, restore, backup =
   let state_file ?(name = "state") () =
     if Fpath.is_seg name then
       Fpath.(!dbdir / name)
@@ -130,6 +130,15 @@ let dump, restore =
      let* exists = Bos.OS.File.exists state_file in
      if exists then
        Bos.OS.File.read state_file
+     else Error `NoFile),
+  (fun ?name backup ->
+     let state_file = state_file ?name ()
+     and backup = state_file ~name:backup ()
+     in
+     let* exists = Bos.OS.File.exists state_file in
+     if exists then
+       let cmd = Bos.Cmd.(v "cp" % p state_file % p backup) in
+       Bos.OS.Cmd.(run_out cmd |> out_null |> success)
      else Error `NoFile)
 
 let block_sub = "block"
diff --git a/src/vmm_unix.mli b/src/vmm_unix.mli
index 1f04707..cafd391 100644
--- a/src/vmm_unix.mli
+++ b/src/vmm_unix.mli
@@ -38,6 +38,8 @@ val dump : ?name:string -> string -> (unit, [> `Msg of string ]) result
 
 val restore : ?name:string -> unit -> (string, [> `Msg of string | `NoFile ]) result
 
+val backup : ?name:string -> string -> (unit, [> `Msg of string | `NoFile ]) result
+
 val unikernel_device : Unikernel.t -> (string, [> `Msg of string ]) result
 
 val manifest_devices_match : bridges:(string * string option * Macaddr.t option) list ->