chore(ci): update deploy workflows - #6018
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
0xcadams
enabled auto-merge
May 19, 2026 07:38
arv
approved these changes
May 19, 2026
| ZERO_ADMIN_PASSWORD: ${{ secrets.ZERO_ADMIN_PASSWORD }} | ||
| run: | | ||
| cd prod/sst | ||
| npm install |
Member
Author
There was a problem hiding this comment.
Removing this npm install breaks the package deps, but I think we should fix this with pnpm workspaces and not add back an npm install after AWS creds are present
| - name: Set up Docker | ||
| uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f # v3 | ||
| - name: Build packages | ||
| run: npx turbo run build |
Member
Author
There was a problem hiding this comment.
I was worried about prebuild/postbuild tasks automatically running in this context.
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 | ||
| with: | ||
| node-version: 24.x | ||
| package-manager-cache: false |
|
|
||
| jobs: | ||
| deploy: | ||
| build: |
Contributor
There was a problem hiding this comment.
I wonder if it would make sense to DRY this with our own .github/actions/
arv
pushed a commit
that referenced
this pull request
May 19, 2026
Refreshes the deploy workflows by splitting package preparation into a separate build job and passing the generated package artifact into the deploy job. Deploy jobs now use GitHub OIDC to assume environment-specific AWS roles, install only deploy-time dependencies, and remove the unused root build helper script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the deploy workflows by splitting package preparation into a separate build job and passing the generated package artifact into the deploy job. Deploy jobs now use GitHub OIDC to assume environment-specific AWS roles, install only deploy-time dependencies, and remove the unused root build helper script.