chore(release): update canary release flow - #6020
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xcadams
commented
May 19, 2026
| function pushNPM(version: string, isCanary: boolean) { | ||
| if (isCanary) { | ||
| execute('npm publish --tag=canary', {cwd: basePath('packages', 'zero')}); | ||
| execute(`npm dist-tag rm @rocicorp/zero@${version} canary`); |
Member
Author
There was a problem hiding this comment.
OIDC does not allow rm tag
Contributor
There was a problem hiding this comment.
what was the intent here?
arv
reviewed
May 19, 2026
| - name: Comment on PR | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ github.token }} |
| function pushNPM(version: string, isCanary: boolean) { | ||
| if (isCanary) { | ||
| execute('npm publish --tag=canary', {cwd: basePath('packages', 'zero')}); | ||
| execute(`npm dist-tag rm @rocicorp/zero@${version} canary`); |
Contributor
There was a problem hiding this comment.
what was the intent here?
arv
pushed a commit
that referenced
this pull request
May 19, 2026
Refreshes the canary release workflow by adding explicit workflow permissions and using OIDC-backed publishing for canary builds. The release path now validates the source ref before invoking git operations, runs the standard canary command, and simplifies the canary npm publish step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the canary release workflow by adding explicit workflow permissions and using OIDC-backed publishing for canary builds. The release path now validates the source ref before invoking git operations, runs the standard canary command, and simplifies the canary npm publish step.