Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes make ws.manifest.main_package_set invalid in package sets init.rb #354

Closed
pierrewillenbrockdfki opened this issue Nov 24, 2021 · 4 comments

Comments

@pierrewillenbrockdfki
Copy link
Contributor

The changes to configuration.rb in commit c7b291c, merged with #335 make ws.manifest.main_package_set nil during execution of package sets init.rb, because the main package set is added last.

Is this change acceptable from autoproj point of view?

This could be fixed by splitting the for loop in two, so the init.rbs get called after all package sets have been re-added.
@2maz

@pierrewillenbrockdfki
Copy link
Contributor Author

Turns out, this is expected behaviour/change.

@doudou
Copy link
Member

doudou commented Nov 24, 2021

@2maz since we already know what's the main package set, and because the main package set is the one that is being imported first (always), can't we set it anyways ?

@g-arjones
Copy link
Contributor

Just out of curiosity why would you want a reference to the main package set in another package set?

I mean, referencing any package set that is not the current one feels like a bad idea to me

@pierrewillenbrockdfki
Copy link
Contributor Author

pierrewillenbrockdfki commented Nov 24, 2021

DFKI has some custom machinery implemented in a package set that would create new files in autoproj/override.d. It uses the main_package_set to trigger a reload of these files. As far as i understand, this machinery will be made obsolete by #336 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants