Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colliding implementations in DistanceFrame #117

Open
m0rsch1 opened this issue Dec 7, 2017 · 1 comment
Open

Colliding implementations in DistanceFrame #117

m0rsch1 opened this issue Dec 7, 2017 · 1 comment

Comments

@m0rsch1
Copy link

m0rsch1 commented Dec 7, 2017

data.resize( (size_t)width * (size_t)height );

This could be colliding with the implementation of the clear method, which sets all values to NaN.
Actually this line should pass as a second argument NaN values as well, right?

@doudou
Copy link
Member

doudou commented Dec 7, 2017

Actually this line should pass as a second argument NaN values as well, right?

I agree that this is not consistent.

I guess that the best would be to pass the desired initialization value as argument, which would at least allow the caller to avoid double-initializing vectors that might be pretty big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants