-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular velocity frame representation #99
Comments
@jhidalgocarrio : any idea ? How are the velocities represented currently w.r.t the source and target frames ? |
This is a wrong assumption (but it is not your fault). Rock naming convention is "IMO" a mess and I have been saying that since the last 3 years. In RBS documentation is written (line26): Then, I assume angular velocity is expressed in sourceFrame which is the moving frame.
It is actually expressed in "target frame". Rock calls it sourceFrame. |
I wholeheartedly agree on that part ... I'm trying to get people to at least document the thing properly so that one can make sense of it. The source/target naming convention being based on the 'frame change' convention (i.e. X/source_RBS(source->target)=X/target), it means that RBS(source->target) is the pose of the source expressed in the target frame, right ? (given that Identity/source_RBS(source->target) = Pose_source/target. If that's right, I get your moving frame / reference frame argument. Basically, if a RBS represents the state of body X in reference Y, sourceFrame = X, targetFrame = Y. |
Thanks for the explanation.
I have to admit it was my case for a while. So, If i got this right regarding the velocities: I just ask myself if there was a reference that was used to define which frame the velocities would be expressed in, or if it is a RBS convention. |
Yes, this is right.
Also true.
This is really good but I don't agree this is the best solution. I think a change (even when it's late) is better than documentation. There are several attempts to improve the issue: #35 #85 |
Actually, it is the right assumption. If source is the moving frame and target the reference frame, body-fixed frame is source (as in RBS represents the pose of "body" in "world") |
Yeap...of course the body frame is a frame fixed to the body (this is the reason why it is called body frame) and body frame is moving w.r.t. the world frame. What I understood from "body fixed frame" is a fixed reference frame or inertial frame of reference. I also got this understanding from the second question ">Why it's not represented in targetFrame, like the velocity?" What I wanted to say is that in rock the sourceFrame is not a fixed reference frame, which is the de factor in many text/books/libraries. Nevertheless, I imagine everything is subject to interpretation. |
Just to be clear: I'm all for picking a convention that matches what looks like the most widely used convention (the way we picked X-forward because it was the standard frame orientation in ROS). Just pointing out that I finally realized that Joao's interpretation of source/target was correct[1] [1] note how long it took me to realize that ... |
+1 |
The RigidBodyState's documentation says the RBS represents the state of the sourceFrame expressed in the targetFrame.
But the angular velocity is expressed in body fixed frame (I'd assume it's the sourceFrame).
Why it's not represented in targetFrame, like the velocity?
The text was updated successfully, but these errors were encountered: