Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate unnecessary extensions #45

Open
dalewking opened this issue Oct 12, 2023 · 1 comment
Open

Don't generate unnecessary extensions #45

dalewking opened this issue Oct 12, 2023 · 1 comment

Comments

@dalewking
Copy link

If you do not have any keys for global_secrets it still generates an unnecessary extension like:

public extension ArkanaKeys {
    struct Global: ArkanaKeysGlobalProtocol {
        public init() {}
    }
}

I presume like wise that if you had no environment_secrets It would also generate similar empty extensions.

You shouldn't generate these useless blocks of code if there are no keys

@rogerluan
Copy link
Owner

Hi @dalewking ! 👋

Good observation! Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants