Commit d3a667b
Kerby Geffrard
Fixes rvlink/rvpush handler when installed outside of C:\ (AcademySoftwareFoundation#323)
<!--
Thanks for your contribution! Please read this comment in its entirety.
It's quite important.
When a contributor merges the pull request, the title and the
description will be used to build the merge commit!
### Pull Request TITLE
It should be in the following format:
[ 12345: Summary of the changes made ] Where 12345 is the corresponding
Github Issue
OR
[ Summary of the changes made ] If it's solving something trivial, like
fixing a typo.
-->
### Linked issues
<!--
Link the Issue(s) this Pull Request is related to.
Each PR should link to at least one issue, in the form:
Use one line for each Issue. This allows auto-closing the related issue
when the fix is merged.
Fixes #12345
Fixes #54345
-->
N/A
### Summarize your change.
Fixes the .bat files that install the rvlink/rvpush URL scheme handlers
by adding an extra \d to the cd calls so we change drive if required
with the change directory call (it's a Windows thing...)
### Describe the reason for the change.
@savoiei reported that if OpenRV is installed on another drive than the
OS drive (C:\ in most cases), the script fails with `Executable file
C:\Windows\bin\rv.exe does not exist. Exiting script.`
The reason behind that is that when cmd.exe starts from explorer.exe,
it's from the directory that contains cmd.exe, and then we try to cd to
the location of the script being executed, to locate rv.exe relative to
the script.
Adding \d tells the cd call to change both the path and the drive,
because they are two separate concepts on Windows.
### Describe what you have tested and on which operating system.
Tested on Windows.
### Add a list of changes, and note any that might need special
attention during the review.
N/A
### If possible, provide screenshots.
N/A
Signed-off-by: Kerby Geffrard <kerby.geffrard@autodesk.com>1 parent 0200db0 commit d3a667b
5 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
0 commit comments