Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any thoughts on supporting Turbo::StreamsChannel? #366

Open
evdevdev opened this issue May 11, 2023 · 1 comment
Open

Any thoughts on supporting Turbo::StreamsChannel? #366

evdevdev opened this issue May 11, 2023 · 1 comment

Comments

@evdevdev
Copy link

Hi there,

Before I say anything else: I love this gem. It is very, very useful!

Next: I've noticed that lograge drops some of the data logged from Turbo Stream.

This:

15:30:49 web.1  | Turbo::StreamsChannel is transmitting the subscription confirmation
15:30:49 web.1  | Turbo::StreamsChannel is streaming from Z2lkOi8vcXVvdGUtYXBwL1F1b3RlUmVxdWVzdC8yMQ:status

Becomes this:

15:34:55 web.1  | method= path= format= params= controller=Turbo::StreamsChannel action=subscribe status=200 duration=0.41

I believe that the details about the specific channel is actually pretty helpful information.

Do you agree? And if so, would you be open to a PR that changes this behavior?

@benlovell
Copy link
Collaborator

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants