Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Improve transaction context handling #613

Open
2 tasks done
shurwit opened this issue Oct 13, 2022 · 1 comment · May be fixed by #631
Open
2 tasks done

[TASK] Improve transaction context handling #613

shurwit opened this issue Oct 13, 2022 · 1 comment · May be fixed by #631
Assignees
@roberlander2
Labels
enhancement New feature or request

Comments

@shurwit
Copy link
Collaborator

shurwit commented Oct 13, 2022 •
edited by roberlander2
Loading

Description

We are currently passing a nullable session context to almost every function in the storage adapter. This adds complexity to the interface functions, and forces the caller to acknowledge internal implementation details.

We should be able to abstract this implementation out from the interface by storing transaction context in the storage adapter struct and creating a new copy of this adapter and setting the new transaction context whenever a transaction is started for use by the caller.

Acceptance Criteria

  • Storage transaction context is no longer exposed/passed in the storage interface functions
  • We have verified that this approach works as expected (no mixups between contexts, transaction operations work as expected)
@shurwit shurwit added the enhancement New feature or request label Oct 13, 2022
roberlander2 added a commit that referenced this issue Dec 15, 2022
@roberlander2
define interfaces package, start using interfaces.Storage for transac…
2301a12 
…tions [#613]
roberlander2 added a commit that referenced this issue Dec 16, 2022
@roberlander2
fix errors [#613]
7c9a94d
roberlander2 added a commit that referenced this issue Dec 16, 2022
@roberlander2
move default storage listener to model package [#613]
0c88452
@roberlander2
Copy link
Contributor

This will depend on #626.

@roberlander2 roberlander2 added the blocked Progress is blocked label Dec 22, 2022
@roberlander2 roberlander2 linked a pull request Jan 24, 2023 that will close this issue
Open
18 tasks
@roberlander2 roberlander2 linked a pull request Jan 24, 2023 that will close this issue
[#613] Improve transaction context handling #631
Open
18 tasks
@roberlander2 roberlander2 removed the blocked Progress is blocked label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberlander2 roberlander2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#613] Improve transaction context handling rokwire/core-building-block
2 participants
@shurwit @roberlander2