Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve expired session deletion efficiency #647

Open
roberlander2 opened this issue Mar 16, 2023 · 0 comments
Open

[FEATURE] Improve expired session deletion efficiency #647

roberlander2 opened this issue Mar 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@roberlander2
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current implementation of the once daily delete expired login sessions timer is not very efficient. It loads 250 sessions and of those, it then deletes the expired ones. This could potentially be improved to delete more than a maximum of 250 (or some other constant) expired sessions per app org.

Describe the solution you'd like
Look into using a single DeleteMany Mongo query to target sessions to be deleted instead of performing multiple storage operations as well as being able to find all expired login sessions for an app org instead of just loading 250 random sessions if a single DeleteMany query is not feasible.

Describe alternatives you've considered
The current implementation may be acceptable with few applications using the system, but as the number of applications grows, the efficiency of this operation becomes more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant