Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1119 catalog capability dynamic form on docker location selection #1122

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

minump
Copy link
Collaborator

@minump minump commented Apr 24, 2023

Description

Docker image name field and environment variables field is displayed dynamically based in "Deployment location" radio button in contribute create and edit pages.
Docker image name and environment variables field is displayed only when the deployment location is internal.
The API base location field is moved up.

Fixes #1119

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@minump minump self-assigned this Apr 24, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add an asterisk to the Docker name to communicate that it's a required field. Environment variables are optional as those can be baked into the docker image.
  • Thee form elements overlap when the internal option is selected. Please fix this.

image

@minump
Copy link
Collaborator Author

minump commented May 2, 2023

Converting to draft for more tests and code changes.

@minump minump marked this pull request as draft May 2, 2023 14:33
@minump
Copy link
Collaborator Author

minump commented Jun 13, 2023

Work on this PR is paused.
This is will worked on after adminWebApp feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Catalog Capability dynamic form display on docker location selection
2 participants