Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Prepare for deployment in OpenShift #17

Open
3 tasks
shurwit opened this issue Jun 20, 2023 · 0 comments · May be fixed by #18
Open
3 tasks

[TASK] Prepare for deployment in OpenShift #17

shurwit opened this issue Jun 20, 2023 · 0 comments · May be fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@shurwit
Copy link
Collaborator

shurwit commented Jun 20, 2023

Description

We are migrating the back-end infrastructure into our new OpenShift cluster. We will need to make some changes for the deployment to succeed.

Acceptance Criteria

  • Add app-env.json: We need to explicitly define all environment variables that we use in a file called app-env.json for the infrastructure to provide them to our containers. This file should be in the following format:
{
    "app_secret": {
        "<SECRET_ENVIRONMENT_VARIABLE>": "<DO NOT PUT ACTUAL SECRET VALUES HERE. Provide a hint or leave empty if the environment variable is optional>",
        ...
    },
    "app_config":{
        "<NON_SECRET_ENVIRONMENT_VARIABLE>": "<Default value or hint. Leave empty if none apply or the environment variable is optional>",
        ...
    }
}
  • Create port environment variable if none exists. Do not specify port in Dockerfile.
  • Ensure that https://github.com/rokwire/logging-library-go is updated to latest version. Apply the following logger options to suppress health checks from OpenShift.
loggerOpts := logs.LoggerOpts{SuppressRequests: logs.NewStandardHealthCheckHTTPRequestProperties(serviceID + "/version")}
@shurwit shurwit added the enhancement New feature or request label Jun 20, 2023
@shurwit shurwit self-assigned this Jun 20, 2023
@akshadpai akshadpai self-assigned this Jul 5, 2023
@akshadpai akshadpai linked a pull request Jul 5, 2023 that will close this issue
18 tasks
@akshadpai akshadpai linked a pull request Jul 5, 2023 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants