Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function hash-table-values is provided by subr-x #7

Closed
wants to merge 1 commit into from
Closed

Function hash-table-values is provided by subr-x #7

wants to merge 1 commit into from

Conversation

mavit
Copy link
Contributor

@mavit mavit commented Jan 5, 2017

pcache's constructor's call to pcache-validate-repo silently fails unless subr-x is required.

This fixes rolandwalker/unicode-fonts#21.

@sigma
Copy link
Owner

sigma commented Jan 5, 2017

Hey, thanks for investigating this.

Would you mind rebasing on top of master? I just pushed a fix for the Travis settings that should take care of the Emacs 25.1 issue.

That said, it looks like subr-x didn't exist before Emacs 24.4, so that require should be guarded by a version check.

Thanks

@mavit
Copy link
Contributor Author

mavit commented Jan 5, 2017

If we don't have subr-x then I think that implies that we don't have hash-table-values, and hence that pcache-validate-repo will never succeed. Doesn't that mean that a test failure is desirable, accurately indicating that pcache isn't working?

@mavit
Function hash-table-values is provided by subr-x
477870c 
`pcache`'s constructor's call to `pcache-validate-repo` silently fails unless `subr-x` is `require`d.

This fixes rolandwalker/unicode-fonts#21.
@sigma
Copy link
Owner

sigma commented Jan 5, 2017

ah, got it. sorry I misunderstood, I thought the function had moved.
Ok, so in this case I prefer to provide a backward-compatible implementation, it's not important enough to give up on the early emacs 24.x. Let me push a fix for that

@sigma sigma closed this Jan 5, 2017
sigma added a commit that referenced this pull request Jan 5, 2017
@sigma
backward-compatible implementation of hash-table-values
b492b56 
the function was introduced in 24.4, which is leaves out some of our
compatility matrix.

This addresses #7
@mavit mavit mentioned this pull request Jan 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remapping unicode fonts on each startup
2 participants
@mavit @sigma