Skip to content

Commit 11f60a3

Browse files
authored
Remove OpenStruct from the project (solve warnings) (#1169)
* Chore: replace references to `OpenStruct` with RSpec doubles * Chore: remove `OpenStruct` exception from `.rubocop.yml`
1 parent c4edf7e commit 11f60a3

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

.rubocop.yml

-2
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,6 @@ Performance/InefficientHashSearch:
156156

157157
Performance/OpenStruct:
158158
Enabled: true
159-
Exclude:
160-
- spec/**/*
161159

162160
Performance/RangeInclude:
163161
Enabled: true

spec/delayed/backend/test.rb

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
require 'ostruct'
21
require 'delayed_job'
32
require 'delayed/backend/base'
43

spec/rollbar_spec.rb

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
require 'active_support/json/encoding'
88

99
require 'rollbar/item'
10-
require 'ostruct'
1110

1211
require 'spec_helper'
1312

@@ -242,7 +241,7 @@
242241
notifier.configuration = configuration
243242
allow_any_instance_of(Net::HTTP)
244243
.to receive(:request)
245-
.and_return(OpenStruct.new(:code => 500, :body => 'Error'))
244+
.and_return(double(code: 500, body: 'Error'))
246245
@uri = URI.parse(Rollbar::Configuration::DEFAULT_ENDPOINT)
247246
end
248247

@@ -1518,7 +1517,7 @@ def backtrace
15181517
before do
15191518
allow_any_instance_of(Net::HTTP)
15201519
.to receive(:request)
1521-
.and_return(OpenStruct.new(:code => 200, :body => 'Success'))
1520+
.and_return(double(code: 200, body: 'Success'))
15221521
@env_vars = clear_proxy_env_vars
15231522
end
15241523

0 commit comments

Comments
 (0)