Skip to content

Commit 196263a

Browse files
authored
fix(buble): prepare for Rollup 3 (#1305)
BREAKING CHANGES: Requires Node 14
1 parent 26a46ed commit 196263a

File tree

7 files changed

+52
-69
lines changed

7 files changed

+52
-69
lines changed

packages/buble/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
## Requirements
1515

16-
This plugin requires an [LTS](https://github.com/nodejs/Release) Node version (v8.0.0+) and Rollup v1.20.0+.
16+
This plugin requires an [LTS](https://github.com/nodejs/Release) Node version (v14.0.0+) and Rollup v1.20.0+.
1717

1818
## Install
1919

packages/buble/package.json

+22-11
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,15 @@
1313
"author": "Rich Harris <[email protected]>",
1414
"homepage": "https://github.com/rollup/plugins/tree/master/packages/buble/#readme",
1515
"bugs": "https://github.com/rollup/plugins/issues",
16-
"main": "dist/rollup-plugin-buble.cjs.js",
17-
"module": "dist/rollup-plugin-buble.es.js",
16+
"main": "./dist/cjs/index.js",
17+
"module": "./dist/es/index.js",
18+
"exports": {
19+
"import": "./dist/es/index.js",
20+
"types": "./types/index.d.ts",
21+
"default": "./dist/cjs/index.js"
22+
},
1823
"engines": {
19-
"node": ">= 8.0.0"
24+
"node": ">=14.0.0"
2025
},
2126
"scripts": {
2227
"build": "rollup -c",
@@ -34,6 +39,7 @@
3439
},
3540
"files": [
3641
"dist",
42+
"!dist/**/*.map",
3743
"types",
3844
"README.md",
3945
"LICENSE"
@@ -47,21 +53,26 @@
4753
"modules"
4854
],
4955
"peerDependencies": {
50-
"rollup": "^1.20.0||^2.0.0"
56+
"rollup": "^1.20.0||^2.0.0||^3.0.0"
57+
},
58+
"peerDependenciesMeta": {
59+
"rollup": {
60+
"optional": true
61+
}
5162
},
5263
"dependencies": {
53-
"@rollup/pluginutils": "^3.1.0",
64+
"@rollup/pluginutils": "^4.2.1",
5465
"@types/buble": "^0.19.2",
5566
"buble": "^0.20.0"
5667
},
5768
"devDependencies": {
58-
"@rollup/plugin-typescript": "^5.0.2",
59-
"del-cli": "^3.0.1",
60-
"rollup": "^2.67.3",
61-
"source-map": "^0.7.3",
62-
"typescript": "4.1.2"
69+
"@rollup/plugin-typescript": "^8.5.0",
70+
"del-cli": "^5.0.0",
71+
"rollup": "^3.0.0-7",
72+
"source-map": "^0.7.4",
73+
"typescript": "^4.8.3"
6374
},
64-
"types": "types/index.d.ts",
75+
"types": "./types/index.d.ts",
6576
"ava": {
6677
"workerThreads": false,
6778
"files": [

packages/buble/rollup.config.js

-13
This file was deleted.

packages/buble/rollup.config.mjs

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { readFileSync } from 'fs';
2+
3+
import { createConfig } from '../../shared/rollup.config.mjs';
4+
5+
export default createConfig({
6+
pkg: JSON.parse(readFileSync(new URL('./package.json', import.meta.url), 'utf8'))
7+
});

packages/buble/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { transform } from 'buble';
22
import { Plugin } from 'rollup';
33
import { createFilter } from '@rollup/pluginutils';
44

5-
import { RollupBubleOptions } from '../types';
5+
import type { RollupBubleOptions } from '../types';
66

77
export default function buble(options: RollupBubleOptions = {}): Plugin {
88
const filter = createFilter(options.include, options.exclude);

packages/buble/test/test.js

+10-12
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,17 @@ const getChunksFromGenerated = (generated) => {
1717
function getChunksFromBundle(bundle) {
1818
return bundle
1919
.generate({
20-
format: 'esm'
20+
format: 'es'
2121
})
2222
.then(getChunksFromGenerated);
2323
}
2424

25-
test('transforms files', async (t) =>
26-
rollup
27-
.rollup({
28-
input: 'fixtures/basic/main.js',
29-
plugins: [buble()]
30-
})
31-
.then(getChunksFromBundle)
32-
.then((generated) => {
33-
t.is(generated.length, 1);
34-
t.is(generated[0].code, 'function main () { return 42; }\n\nexport { main as default };\n');
35-
}));
25+
test('transforms files', async (t) => {
26+
const bundle = await rollup.rollup({
27+
input: `${__dirname}/fixtures/basic/main.js`,
28+
plugins: [buble()]
29+
});
30+
const generated = await getChunksFromBundle(bundle);
31+
t.is(generated.length, 1);
32+
t.is(generated[0].code, 'function main () { return 42; }\n\nexport { main as default };\n');
33+
});

pnpm-lock.yaml

+11-31
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)