-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shutdown issues. #179
base: master
Are you sure you want to change the base?
Fix shutdown issues. #179
Conversation
cling is currently tearing down the text input before the Interpreter is destroyed. Leading to problems with pipes and file handles being close in the text input layer.
lib/Utils/PlatformWin.cpp
Outdated
|
||
// Remove the ImageBase from lookup | ||
// There is a chance that DeRegisterEHFrames will without a prior call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
…tor. DeRegisterEHFrames can be called without a a prior call to RegisterEHFrames. This can easily be detected so just do nothing when that occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as Windows is concerned, since I don't see any difference on my desktop machine, I would say it is fine with me...
UserInterface was being destroyed to early, possibly upsetting the text-input layer on Windows.
Remove an assert for Windows exception handling that was triggering too late in shutdown to be seen and hand condition at runtime.