Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown issues. #179

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

marsupial
Copy link
Contributor

UserInterface was being destroyed to early, possibly upsetting the text-input layer on Windows.
Remove an assert for Windows exception handling that was triggering too late in shutdown to be seen and hand condition at runtime.

cling is currently tearing down the text input before the Interpreter is destroyed.
Leading to problems with pipes and file handles being close in the text input layer.

// Remove the ImageBase from lookup
// There is a chance that DeRegisterEHFrames will without a prior call to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

…tor.

DeRegisterEHFrames can be called without a a prior call to RegisterEHFrames.
This can easily be detected so just do nothing when that occurs.
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as Windows is concerned, since I don't see any difference on my desktop machine, I would say it is fine with me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants