[tmva][sofie] Disentangle PyMVA and SOFIE #20355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
pymva_status
branch
from
eae03d6 to
8a1bbdc
Compare
guitargeek
changed the title
guitargeek
force-pushed
the
pymva_status
branch
from
8a1bbdc to
2dbbe7d
Compare
The output with the version info when the module is found is very useful.
guitargeek
force-pushed
the
pymva_status
branch
from
2dbbe7d to
3c6791c
Compare
guitargeek
changed the title
Also, fix the comparison of the status code retuned by the Python invokation.
So far, the part of SOFIE that uses the C Python API was included in PyMVA for convenience, but the functionality is completely unrelated. Moving this code to SOFIE itself means we can fully build and test SOFIE without enabling `tmva-pymva`. The only subtelty is that we want to be able to disable these SOFIE features that require linking against `libpython`, because this is not always allowed (e.g. in the Python wheels). Therefore, this part is only built if we build also the other ROOT libraries that links against `libpython` besides PyMVA, wich is `TPython`.
This keyword argument is not relevant for defining the model and will cause errors in newer Keras versions.
guitargeek
force-pushed
the
pymva_status
branch
from
3c6791c to
0305b56
Compare
Test Results 21 files 21 suites 3d 17h 19m 36s ⏱️ Results for commit 0305b56. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the part of SOFIE that uses the C Python API was included in PyMVA for convenience, but the functionality is completely unrelated.
Moving this code to SOFIE itself means we can fully build and test SOFIE without enabling
tmva-pymva.The only subtelty is that we want to be able to disable these SOFIE features that require linking against
libpython, because this is not always allowed (e.g. in the Python wheels). Therefore, this part is only built if we build also the other ROOT libraries that links againstlibpythonbesides PyMVA, wich isTPython.