Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid ORCID #200

Open
karthik opened this issue May 15, 2018 · 4 comments
Open

Check for valid ORCID #200

karthik opened this issue May 15, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@karthik
Copy link

karthik commented May 15, 2018

At rOpenSci we encourage onboarding authors to add their ORCIDs to the description files. We have also been tagging reviewers (where appropriate) with their researcher IDs as well. Right now the only thing CRAN does is regex for these IDs (it does not ensure a valid id or that the id belongs to an author) and then link out to the appropriate profile via an icon on the cran package page. In the future it's conceivable that CRAN updates may result in automatic updates on author records (we are far from it, but adding ORCIDs is the first step)

These also become part of the codemeta manifest which is parsed by the codemetar package.

Proposal: Goodpractice could check that the ORCID is valid and also belongs to the author (to catch issues like multiple copy paste errors) and report out if there is a mismatch. This can be done using the orcid API, and possibly made optional. I'm happy to contribute this as a PR if you think this would be a good fit for goodpractice.

@maelle
Copy link
Contributor

maelle commented May 15, 2018

Cf https://github.com/ropensci/rorcid

@karthik
Copy link
Author

karthik commented May 15, 2018

The orcid api does not work without authentication, even to just check the validity of an id. One way would just be to scape the name off a page and see if it matches the desc::desc_get_author() name.

library(rvest)
urrl <- "https://orcid.org/0000-0002-0233-1757"
name <- read_html(urrl) %>% 
  html_nodes(".full-name") %>% 
  html_text()  %>% 
  gsub("[\r\n]", "", .)

@mpadge
Copy link
Member

mpadge commented May 28, 2024

rOpenSci has now taken over maintenance of this package, as part of which we're cleaning out old issues. {goodpractice} will remain focussed on package-internal issues, so this one will be moved to our more general {pkgcheck} package.

@mpadge mpadge transferred this issue from ropensci-review-tools/goodpractice May 28, 2024
@assignUser
Copy link
Collaborator

rOpenSci has now taken over maintenance of this package

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants