Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: pkgcheck
Title: rOpenSci Package Checks
Version: 0.1.2.257
Version: 0.1.2.260
Authors@R: c(
person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-2172-5265")),
Expand Down
14 changes: 8 additions & 6 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ RUN Rscript -e 'reticulate::virtualenv_create()'
# Extra python packages:
# ---- Authors: Please submit PRs which insert extra python requirements here,
# ---- followed by package name and "#<ropensci/software-review issue number>":
RUN /root/.virtualenvs/r-reticulate/bin/pip install earthengine-api # rgeeExtra #608
# See rgeeExtra #608 for this one:
RUN /root/.virtualenvs/r-reticulate/bin/pip install earthengine-api

# arrow docs suggest this shouldn't be needed, but s3
# support doesn't work without re-install/compile:
Expand All @@ -318,8 +319,9 @@ RUN Rscript -e 'arrow::install_arrow()'
RUN Rscript -e 'bspm::disable();install.packages(c("sf","terra"));bspm::enable()'

# Quarto binary:
RUN wget https://github.com/quarto-dev/quarto-cli/releases/download/v1.6.40/quarto-1.6.40-linux-amd64.tar.gz \
&& mkdir ~/opt \
&& tar -C ~/opt -xvzf quarto-1.6.40-linux-amd64.tar.gz \
&& ln -s ~/opt/quarto-1.6.40/bin/quarto /usr/local/bin/quarto \
&& rm quarto-1.6.40-linux-amd64.tar.gz
RUN QUARTO_VERSION=$(curl -s https://api.github.com/repos/quarto-dev/quarto-cli/releases/latest | grep '"tag_name"' | sed -E 's/.*"tag_name": *"(v[^"]+)".*/\1/') \
&& wget https://github.com/quarto-dev/quarto-cli/releases/download/${QUARTO_VERSION}/quarto-${QUARTO_VERSION#v}-linux-amd64.tar.gz \
&& mkdir -p ~/opt \
&& tar -C ~/opt -xvzf quarto-${QUARTO_VERSION#v}-linux-amd64.tar.gz \
&& ln -s ~/opt/quarto-${QUARTO_VERSION#v}/bin/quarto /usr/local/bin/quarto \
&& rm quarto-${QUARTO_VERSION#v}-linux-amd64.tar.gz
2 changes: 1 addition & 1 deletion codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"codeRepository": "https://github.com/ropensci-review-tools/pkgcheck",
"issueTracker": "https://github.com/ropensci-review-tools/pkgcheck/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.1.2.257",
"version": "0.1.2.260",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down
24 changes: 12 additions & 12 deletions tests/testthat/_snaps/extra-checks/checks-extra.html
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ <h3>3. Statistical Properties</h3>
<li>no internal data file</li>
<li>9 imported packages</li>
<li>11 exported functions (median 43 lines of code)</li>
<li>120 non-exported functions in R (median 21 lines of code)</li>
<li>53 non-exported functions in R (median 14 lines of code)</li>
<li>12 R functions (median 16 lines of code)</li>
</ul>
<hr />
Expand Down Expand Up @@ -280,8 +280,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Total number of exported and non-exported R functions">n_fns_r</a></td>
<td align="right">131</td>
<td align="right">82.3</td>
<td align="right">64</td>
<td align="right">64.5</td>
<td align="left"></td>
</tr>
<tr class="even">
Expand All @@ -292,8 +292,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Total number of non-exported R functions">n_fns_r_not_exported</a></td>
<td align="right">120</td>
<td align="right">86.6</td>
<td align="right">53</td>
<td align="right">69.2</td>
<td align="left"></td>
</tr>
<tr class="even">
Expand All @@ -305,7 +305,7 @@ <h3>3. Statistical Properties</h3>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Median number of functions per R source file">n_fns_per_file_r</a></td>
<td align="right">4</td>
<td align="right">59.9</td>
<td align="right">58.0</td>
<td align="left"></td>
</tr>
<tr class="even">
Expand All @@ -322,8 +322,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Median number of lines of code for each R function">loc_per_fn_r</a></td>
<td align="right">23</td>
<td align="right">66.5</td>
<td align="right">17</td>
<td align="right">52.5</td>
<td align="left"></td>
</tr>
<tr class="odd">
Expand All @@ -334,8 +334,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Median number of lines of code for each non-exported R function">loc_per_fn_r_not_exp</a></td>
<td align="right">22</td>
<td align="right">67.4</td>
<td align="right">14</td>
<td align="right">46.9</td>
<td align="left"></td>
</tr>
<tr class="odd">
Expand Down Expand Up @@ -370,8 +370,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Median number of lines of documentation for each non-exported R function">doclines_per_fn_not_exp</a></td>
<td align="right">0</td>
<td align="right">0.0</td>
<td align="right">3</td>
<td align="right">100.0</td>
<td align="left">TRUE</td>
</tr>
<tr class="odd">
Expand Down
14 changes: 7 additions & 7 deletions tests/testthat/_snaps/extra-checks/checks-extra.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ The package has:
- no internal data file
- 9 imported packages
- 11 exported functions (median 43 lines of code)
- 120 non-exported functions in R (median 21 lines of code)
- 53 non-exported functions in R (median 14 lines of code)
- 12 R functions (median 16 lines of code)

---
Expand All @@ -129,22 +129,22 @@ The final measure (`fn_call_network_size`) is the total number of calls between
|loc_src | 277| 34.4| |
|loc_tests | 266| 61.0| |
|num_vignettes | 0| 0.0|TRUE |
|n_fns_r | 131| 82.3| |
|n_fns_r | 64| 64.5| |
|n_fns_r_exported | 11| 49.4| |
|n_fns_r_not_exported | 120| 86.6| |
|n_fns_r_not_exported | 53| 69.2| |
|n_fns_src | 12| 42.5| |
|n_fns_per_file_r | 4| 59.9| |
|n_fns_per_file_r | 4| 58.0| |
|n_fns_per_file_src | 4| 47.5| |
|num_params_per_fn | 1| 1.7|TRUE |
|loc_per_fn_r | 23| 66.5| |
|loc_per_fn_r | 17| 52.5| |
|loc_per_fn_r_exp | 43| 75.4| |
|loc_per_fn_r_not_exp | 22| 67.4| |
|loc_per_fn_r_not_exp | 14| 46.9| |
|loc_per_fn_src | 16| 56.9| |
|rel_whitespace_R | 19| 88.6| |
|rel_whitespace_src | 24| 44.2| |
|rel_whitespace_tests | 27| 64.5| |
|doclines_per_fn_exp | 31| 36.1| |
|doclines_per_fn_not_exp | 0| 0.0|TRUE |
|doclines_per_fn_not_exp | 3| 100.0|TRUE |
|fn_call_network_size | 111| 80.8| |

---
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/extra-checks/checks-print.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ i Package has
* No internal data
* 9 imported packages.
* 11 exported functions (median 43 lines of code).
* 120 non-exported functions (median 21 lines of code).
* 53 non-exported functions (median 14 lines of code).
* 12 C++ functions (median 16 lines of code).
* 1 parameters per function (median).

Expand Down
18 changes: 12 additions & 6 deletions tests/testthat/_snaps/pkgcheck/checks0.html
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ <h3>3. Statistical Properties</h3>
<li>no internal data file</li>
<li>1 imported package</li>
<li>1 exported function (median 3 lines of code)</li>
<li>2 non-exported functions in R (median 3 lines of code)</li>
<li>1 non-exported function in R (median 3 lines of code)</li>
<li>2 R functions (median 5 lines of code)</li>
</ul>
<hr />
Expand Down Expand Up @@ -277,8 +277,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Total number of exported and non-exported R functions">n_fns_r</a></td>
<td align="right">3</td>
<td align="right">4.3</td>
<td align="right">2</td>
<td align="right">1.8</td>
<td align="left">TRUE</td>
</tr>
<tr class="even">
Expand All @@ -289,8 +289,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Total number of non-exported R functions">n_fns_r_not_exported</a></td>
<td align="right">2</td>
<td align="right">4.4</td>
<td align="right">1</td>
<td align="right">1.8</td>
<td align="left">TRUE</td>
</tr>
<tr class="even">
Expand Down Expand Up @@ -367,11 +367,17 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Median number of lines of documentation for each non-exported R function">doclines_per_fn_not_exp</a></td>
<td align="right">2</td>
<td align="right">4</td>
<td align="right">100.0</td>
<td align="left">TRUE</td>
</tr>
<tr class="odd">
<td align="left">doclines_per_fn_src</td>
<td align="right">1</td>
<td align="right">73.6</td>
<td align="left"></td>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Total number of calls from one package function to another">fn_call_network_size</a></td>
<td align="right">1</td>
<td align="right">11.7</td>
Expand Down
9 changes: 5 additions & 4 deletions tests/testthat/_snaps/pkgcheck/checks0.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ The package has:
- no internal data file
- 1 imported package
- 1 exported function (median 3 lines of code)
- 2 non-exported functions in R (median 3 lines of code)
- 1 non-exported function in R (median 3 lines of code)
- 2 R functions (median 5 lines of code)

---
Expand All @@ -215,9 +215,9 @@ The final measure (`fn_call_network_size`) is the total number of calls between
|loc_src | 26| 2.7|TRUE |
|loc_tests | 6| 5.1| |
|num_vignettes | 0| 0.0|TRUE |
|n_fns_r | 3| 4.3|TRUE |
|n_fns_r | 2| 1.8|TRUE |
|n_fns_r_exported | 1| 1.6|TRUE |
|n_fns_r_not_exported | 2| 4.4|TRUE |
|n_fns_r_not_exported | 1| 1.8|TRUE |
|n_fns_src | 2| 12.0| |
|n_fns_per_file_r | 1| 1.8|TRUE |
|n_fns_per_file_src | 1| 7.3| |
Expand All @@ -230,7 +230,8 @@ The final measure (`fn_call_network_size`) is the total number of calls between
|rel_whitespace_src | 27| 4.9|TRUE |
|rel_whitespace_tests | 17| 2.8|TRUE |
|doclines_per_fn_exp | 6| 2.3|TRUE |
|doclines_per_fn_not_exp | 2| 100.0|TRUE |
|doclines_per_fn_not_exp | 4| 100.0|TRUE |
|doclines_per_fn_src | 1| 73.6| |
|fn_call_network_size | 1| 11.7| |

---
Expand Down
18 changes: 12 additions & 6 deletions tests/testthat/_snaps/pkgcheck/checks1.html
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ <h3>3. Statistical Properties</h3>
<li>no internal data file</li>
<li>1 imported package</li>
<li>1 exported function (median 3 lines of code)</li>
<li>2 non-exported functions in R (median 3 lines of code)</li>
<li>1 non-exported function in R (median 3 lines of code)</li>
<li>2 R functions (median 5 lines of code)</li>
</ul>
<hr />
Expand Down Expand Up @@ -279,8 +279,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Total number of exported and non-exported R functions">n_fns_r</a></td>
<td align="right">3</td>
<td align="right">4.3</td>
<td align="right">2</td>
<td align="right">1.8</td>
<td align="left">TRUE</td>
</tr>
<tr class="even">
Expand All @@ -291,8 +291,8 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="odd">
<td align="left"><a tooltip="tooltip" title="Total number of non-exported R functions">n_fns_r_not_exported</a></td>
<td align="right">2</td>
<td align="right">4.4</td>
<td align="right">1</td>
<td align="right">1.8</td>
<td align="left">TRUE</td>
</tr>
<tr class="even">
Expand Down Expand Up @@ -369,11 +369,17 @@ <h3>3. Statistical Properties</h3>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Median number of lines of documentation for each non-exported R function">doclines_per_fn_not_exp</a></td>
<td align="right">2</td>
<td align="right">4</td>
<td align="right">100.0</td>
<td align="left">TRUE</td>
</tr>
<tr class="odd">
<td align="left">doclines_per_fn_src</td>
<td align="right">1</td>
<td align="right">73.6</td>
<td align="left"></td>
</tr>
<tr class="even">
<td align="left"><a tooltip="tooltip" title="Total number of calls from one package function to another">fn_call_network_size</a></td>
<td align="right">1</td>
<td align="right">11.7</td>
Expand Down
9 changes: 5 additions & 4 deletions tests/testthat/_snaps/pkgcheck/checks1.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ The package has:
- no internal data file
- 1 imported package
- 1 exported function (median 3 lines of code)
- 2 non-exported functions in R (median 3 lines of code)
- 1 non-exported function in R (median 3 lines of code)
- 2 R functions (median 5 lines of code)

---
Expand All @@ -217,9 +217,9 @@ The final measure (`fn_call_network_size`) is the total number of calls between
|loc_src | 26| 2.7|TRUE |
|loc_tests | 6| 5.1| |
|num_vignettes | 0| 0.0|TRUE |
|n_fns_r | 3| 4.3|TRUE |
|n_fns_r | 2| 1.8|TRUE |
|n_fns_r_exported | 1| 1.6|TRUE |
|n_fns_r_not_exported | 2| 4.4|TRUE |
|n_fns_r_not_exported | 1| 1.8|TRUE |
|n_fns_src | 2| 12.0| |
|n_fns_per_file_r | 1| 1.8|TRUE |
|n_fns_per_file_src | 1| 7.3| |
Expand All @@ -232,7 +232,8 @@ The final measure (`fn_call_network_size`) is the total number of calls between
|rel_whitespace_src | 27| 4.9|TRUE |
|rel_whitespace_tests | 17| 2.8|TRUE |
|doclines_per_fn_exp | 6| 2.3|TRUE |
|doclines_per_fn_not_exp | 2| 100.0|TRUE |
|doclines_per_fn_not_exp | 4| 100.0|TRUE |
|doclines_per_fn_src | 1| 73.6| |
|fn_call_network_size | 1| 11.7| |

---
Expand Down