Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle ODBC's connection classes #185

Open
jonkeane opened this issue Feb 25, 2024 · 0 comments
Open

Better handle ODBC's connection classes #185

jonkeane opened this issue Feb 25, 2024 · 0 comments

Comments

@jonkeane
Copy link
Collaborator

ODBC actually returns connections of classes that it defines itself. As of ODBC 1.4.2, not all of these are exported (e.g. PostgreSQL is the resultant class of the connection, but that is not exported (though it is on main)).

One can see how ODBC does this at https://github.com/r-dbi/odbc/blob/f5bf80dd23547d289332ba2c01c91b455e8e98de/R/odbc-connection.R#L57-L64

Could we (and should we) save the class during the capturing process and then construct the class from that when mock-connecting?

PR #184 works around the issue that triggered me to realize this by hardcoding the seemingly one thing that dbplyr uses dispatch for that class on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant