Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal to user if ITIS response is empty #27

Open
jcblum opened this issue Dec 1, 2023 · 1 comment
Open

Signal to user if ITIS response is empty #27

jcblum opened this issue Dec 1, 2023 · 1 comment
Labels
feature

Comments

@jcblum
Copy link
Contributor

jcblum commented Dec 1, 2023

Current behavior is to silently return an empty data frame. It would be nicer to also include a warning that the response from ITIS was completely empty (no fields).

See #26, where a transient ITIS outage was leading to an empty string getting passed into parse_raw() (but apparently no HTTP errors were detected?).
@jcblum jcblum added the feature label Dec 1, 2023
@rix133
Copy link

rix133 commented Dec 1, 2023

(but apparently no HTTP errors were detected?).

Yes, no HTTP errors of any sort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix133 @jcblum