Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enhancements to select file tab #158

Open
elinw opened this issue Jul 26, 2019 · 4 comments
Open

add enhancements to select file tab #158

elinw opened this issue Jul 26, 2019 · 4 comments

Comments

@elinw
Copy link
Collaborator

elinw commented Jul 26, 2019

Now that the other tabs are hidden when no file is selected, move that process to a tab (that is not hidden by the conditional).

In addition to the select option ... create a UI that supports the following steps.

If the selected file does not validate -> two possibilities, select again (this works now but with a warning #156 ) or "Create project at this location." If the user selects the Create option, they then should supply a project name (although a default could be supplied? Would need to check that it doesn't exist).

Then there should be a button for importing the data. However the UI should point out that the user should put their data in place prior to importing or else empty files will be created.

At that point the other tabs should become available.

@elinw
Copy link
Collaborator Author

elinw commented Jul 26, 2019

@Jones-Git Are you up for this?

@Jones-Git
Copy link
Contributor

I shall take a crack at it.

@elinw
Copy link
Collaborator Author

elinw commented Jul 29, 2019

I moved it to the tab ... that is in master. You'll want to look at the validation process and what is returned when the file selected does not pass validation, then respond to that with the offer to create a project in the selected folder ... they will need to provide a name (so you need an empty field) and then a button.
Then ask if they want to import data.

@elinw elinw changed the title Move select file to a tab and add enhancements add enhancements to select file tab Aug 19, 2019
@elinw
Copy link
Collaborator Author

elinw commented Aug 19, 2019

We probably need to change the validation so that it returns FALSE if it is not valid. Also make the message return in the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants