Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change Axis.msg to use radians instead of degrees #71

Open
civerachb-cpr opened this issue Jun 20, 2022 · 0 comments
Open

Proposal: Change Axis.msg to use radians instead of degrees #71

civerachb-cpr opened this issue Jun 20, 2022 · 0 comments

Comments

@civerachb-cpr
Copy link
Collaborator

I'm writing this as the maintainer of the package. When I inherited this project, the package was already released using degree for the pan and tilt positions in the Axis messages. Obviously the ROS standard is to use radians.

I'm hesitant to change the units used by the package simply because it's been released and used in its current state for years. But the fact that the message uses non-standard units makes interoperability with other ROS packages less convenient.

My initial proposal is to add a new rosparam option to the PTZ node to specify the units:

<node pkg="axis_camera" type="teleop.py" name="teleop" if="$(arg enable_ptz_teleop)">
  <param name="use_degrees" value="1" />
  <param name="enable_button" value="1" />
  <param name="scale_pan_deg" value="25" />
  <param name="scale_tilt_deg" value="25" />
  <remap from="joy" to="/joy" />
</node>

I'd like to use radians by default, as this is the ROS standard. But initially the default may remain degrees so as not to break anything that depends on this package.

Before I implement any of this work, I'm going to leave this issue open to solicit feedback from the wider community. If you have opinions on this proposal, please leave them below!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant