You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm writing this as the maintainer of the package. When I inherited this project, the package was already released using degree for the pan and tilt positions in the Axis messages. Obviously the ROS standard is to use radians.
I'm hesitant to change the units used by the package simply because it's been released and used in its current state for years. But the fact that the message uses non-standard units makes interoperability with other ROS packages less convenient.
My initial proposal is to add a new rosparam option to the PTZ node to specify the units:
I'd like to use radians by default, as this is the ROS standard. But initially the default may remain degrees so as not to break anything that depends on this package.
Before I implement any of this work, I'm going to leave this issue open to solicit feedback from the wider community. If you have opinions on this proposal, please leave them below!
The text was updated successfully, but these errors were encountered:
I'm writing this as the maintainer of the package. When I inherited this project, the package was already released using degree for the
pan
andtilt
positions in theAxis
messages. Obviously the ROS standard is to use radians.I'm hesitant to change the units used by the package simply because it's been released and used in its current state for years. But the fact that the message uses non-standard units makes interoperability with other ROS packages less convenient.
My initial proposal is to add a new
rosparam
option to the PTZ node to specify the units:I'd like to use radians by default, as this is the ROS standard. But initially the default may remain degrees so as not to break anything that depends on this package.
Before I implement any of this work, I'm going to leave this issue open to solicit feedback from the wider community. If you have opinions on this proposal, please leave them below!
The text was updated successfully, but these errors were encountered: