Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform this into an extendable template. #13

Open
firstprayer opened this issue Mar 4, 2015 · 1 comment
Open

Transform this into an extendable template. #13

firstprayer opened this issue Mar 4, 2015 · 1 comment

Comments

@firstprayer
Copy link

From my experience, extending this driver is not difficult. If I need more data, all I need to do is to define more fields in the message, add some very trivial code, and it works. So, reading more data is not a problem.

But, what if someone what less data? Transform more data clearly make it less efficient, under the case where only very simple data is needed.

There're two ways, perhaps:

  1. Make the module configurable. That is, the user can configure what input he needs
  2. Or, in a simpler way, just provide the driver as a template/skeleton, which only provides the simplest data. At the mean time, the actual user of the driver can easily add new data input by making very few modifications.

I actually recommend the latter approach. The basic idea is like https://github.com/angular/angular-seed

Let me know the your comments on this idea :)

@130s
Copy link
Member

130s commented Mar 7, 2015

@firstprayer Though without taking a deeper look, your idea sounds interesting, and probably worth asking in more higher level community, like drivers SIG.

Just from curiosity for Leap driver, do you have particular types of data you want to receive/omit?

Also, speaking of the performance I just opened #14 for the configurable ROS message frequency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants