[bug] Using UDP communication, some statements fail to match because line breaks are not cleanly filtered.

[zymouse]

settled

• brach: ros2
• commit: 861323c
• Already read the document
• Debugging the code to make sure it's a code bug
• Tested TCP and UDP against each other: no problems with TCP, problems with UDP line breaks `\r
• Grab packets via wireshark:
  • Make sure there are no problems with the data
  • Determine that TCP and UDP are receiving the same data

## Description of the problem UDP test: match failed because a statement line break was not filtered cleanly

nmea_navsat_driver/src/libnmea_navsat_driver/parser.py

Line 288 in b168f49

r'(^\$GP|^\$GN|^\$GL|^\$IN).*\*[0-9A-Fa-f]{2}$', nmea_sentence):

Possible causes

nmea_navsat_driver/src/libnmea_navsat_driver/nodes/nmea_socket_driver.py

Line 81 in 861323c

data_list = data.decode("ascii").strip().split("\n")

[zymouse]

@ericperko extremely grateful

With this modification, the test passes ✅

[ericperko]

@zymouse I think you want the current maintainer for this project, @evenator

[evenator]

@zymouse Your analysis of the situation appears to be correct and I would welcome a pull request to fix the bug.

[zymouse]

@evenator #174
It was a pleasure to maintain the program and make him better.