feat(order_execution): adds OrderManager #3
+6,242
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
shawnkchan
changed the title
shawnkchan
changed the title
…ared_ptr to node Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Fix on Issue #4: Required APIs from StateMananger.
…to it and changing update_current_order Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
… update Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
This was referenced Nov 18, 2025
Member
|
Thanks for all the great work on this! Some high-level feedback:
|
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
* fix: export fmt as a dependency for downstream packages Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> * feat: add vda5050 structs for internal use Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> * feat: overload equality/inequality operators Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> * feat: add action.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add action_parameter.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add action_parameter_factsheet.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add action_parameter_value.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add action_parameter_value_type.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add action_scope.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add blocking_type.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add agv_action.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add value_data_type.hpp Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * feat: add remaining structs for vda5050 messages Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> * fix: change action param to have key-value pairs instead of custom type Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> * fix: remove optional from action array Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> * fix: remove deleted include Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> * Update vda5050_types/include/vda5050_types/agv_action.hpp * Update vda5050_types/include/vda5050_types/node.hpp * Update vda5050_types/include/vda5050_types/node.hpp --------- Signed-off-by: Saurabh Kamat <saurabh_kamat@artc.a-star.edu.sg> Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com> Co-authored-by: Shawn Chan <shawnkengkiat@gmail.com> Co-authored-by: Shawn Chan <83695082+shawnkchan@users.noreply.github.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
…al fields Signed-off-by: Shawn Chan <shawnkengkiat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Raising this PR to get feedback on my implementation for the order execution logic. This PR covers Order execution - Order Parsing and Order execution - Node Sequencing.
This PR contains the following features:
NOTE:
IStateManager.hppis a temporary class for mocking the StateManger in the unit tests.