We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'm trying to point vcs-repo-file-url to a repos file that exists in the root of the same repository as where the action is being run. e.g.:
vcs-repo-file-url
vcs-repo-file-url: | https://raw.githubusercontent.com/ros2/ros2/dashing/ros2.repos "${{ github.workspace }}\ros2_java_desktop.repos"
But, curl fails since the necessary file:// prefix is not being appended by the action.
curl
file://
file:// is appended by the logic here:
action-ros-ci/src/action-ros-ci.ts
Lines 52 to 54 in 242ffcc
and curl succeeds.
curl fails. For example.
See example workflow in ros2-java/ros2_java#109.
I'm not sure if this is user error, or a bug related to the use of fs.existsSync on Windows.
fs.existsSync
The text was updated successfully, but these errors were encountered:
Looks like if I remove the quotation marks ("), then the action works as expected. For example:
"
vcs-repo-file-url: | https://raw.githubusercontent.com/ros2/ros2/dashing/ros2.repos - "${{ github.workspace }}\ros2_java_desktop.repos" + ${{ github.workspace }}\ros2_java_desktop.repos
Maybe the action could be more robust to the presence of quotation marks, but seems like user-error on my part.
Edit: I'll note that the quotation marks didn't seem to be a problem on Linux.
Sorry, something went wrong.
No branches or pull requests
Description
I'm trying to point
vcs-repo-file-url
to a repos file that exists in the root of the same repository as where the action is being run. e.g.:But,
curl
fails since the necessaryfile://
prefix is not being appended by the action.Expected Behavior
file://
is appended by the logic here:action-ros-ci/src/action-ros-ci.ts
Lines 52 to 54 in 242ffcc
and
curl
succeeds.Actual Behavior
curl
fails. For example.To Reproduce
See example workflow in ros2-java/ros2_java#109.
System (please complete the following information)
Additional context
I'm not sure if this is user error, or a bug related to the use of
fs.existsSync
on Windows.The text was updated successfully, but these errors were encountered: