-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build-errors due to format-security #1108
Comments
Seems to originate from:
The security_flags.inc file even contains a few exceptions already:
Suggested fix:
Is |
Thanks for reporting this. I would suggest keeping it localized to the recipe. There doesn't appear to be a bbappend for teleop-twist-joy but there is one for nav2-costmap-2d: You could set SECURITY_STRINGFORMAT = "" as one possible fix. meta-ros/meta-ros1-melodic/recipes-bbappends/microstrain-mips/microstrain-mips_0.0.3-1.bbappend Line 13 in e45cd71
Another route would be to demote the error back to a warning with: That may be more suitable as it shows the intent and may be more obvious to remove when no longer needed. |
Describe the bug
Same build error as in #1096
string-format warning in upstream code causes compilation error with default compiler flag.
To Reproduce
Using latest
meta-ros
on branchkirkstone
:meta-ros2-humble = "HEAD:685215f9837d47089d2eaaa296c1dac574f44ddf"
meta-poky = "HEAD:6505459809380ddcf152a09343e4dc55038de332"
Running:
bitbake teleop-twist-joy
orbitbake nav2-costmap-2d
Log:
Expected behavior
Builds without error (but with warnings?)
Seems the problem is upstream code which relies on printf without format-strings. So the warning is valid, but the handling as error causes issues for us.
The text was updated successfully, but these errors were encountered: