Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing xml comment in package.xml #240

Open
ashwinvkNV-zz opened this issue Oct 3, 2022 · 0 comments
Open

Error parsing xml comment in package.xml #240

ashwinvkNV-zz opened this issue Oct 3, 2022 · 0 comments

Comments

@ashwinvkNV-zz
Copy link

Issue:
When a comment(eg: license) is added using the <!-- example_comment --> format before the tag in the package.xml file of a rviz plugin, pluginlib exits with the following error:
Could not find a root element for package manifest at
This is because the tinyxml2::XMLDocument function FirstChildElement("package") returns NULL when a XML comment is present before the "package" child element. https://github.com/ros/pluginlib/blob/ros2/pluginlib/include/pluginlib/class_loader_imp.hpp#L300

Branch: ros2

Commit Hash: b0388a8

Workaround:
Adding the comment using a non-existing processing-instruction works as expected.

eg:

<?comment
  example comment
?>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant