Fix ExecuteLocal output flushing

[mhidalgo-bdai]

Closes #859. Partially backports #679.

[fujitatomoya]

lgtm with green CI.

[fujitatomoya]

Pulls: #860
Gist: https://gist.githubusercontent.com/fujitatomoya/eb5c0f0057f10804f06ee3078c56589f/raw/11bdb644dd5cebe84d977829fe74fb9b2a753f0b/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15711

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[mhidalgo-bdai]

Hmm, test failures seem unrelated to this patch.

@fujitatomoya can we re-run the aarch64 job? It failed on a Jenkins hiccup, it seems.

[christophebedard]

Retriggered!

[fujitatomoya]

dev branch is 127 commits behind from rolling, i think we need to rebase and restart the CI.

[fujitatomoya]

@Mergifyio rebase

[mergify]

rebase

☑️ Nothing to do

• any of:
  • #commits > 1 [📌 rebase requirement]
  • #commits-behind > 0 [📌 rebase requirement]
  • -linear-history [📌 rebase requirement]
• -closed [📌 rebase requirement]
• -conflict [📌 rebase requirement]
• queue-position = -1 [📌 rebase requirement]

[fujitatomoya]

@mhidalgo-bdai can you rebase your branch to rolling? Mergifyio cannot seem to do that. and then I can start the CI again.

[christophebedard]

This PR targets the humble branch 😁

[mhidalgo-bdai]

This PR targets the humble branch 😁

Indeed. This was fixed in Iron by a seemingly unrelated patch, see #679.

[fujitatomoya]

@mhidalgo-bdai @christophebedard ah sorry 😓 my bad, totally forgot that this is backport.

[fujitatomoya]

RHEL and Windows warnings are unrelated.