You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the format of the timestamp. Should we provide a format string option for the user to specify how they'd like their timestamps output?
ROS Time - should the timestamps conform to simulation time when it's provided? Is that an option we even are able to enable on the recorder right now?
Clock adjustments: if using system time, theoretically it could jump backward and potentially create the same filename twice - probably extremely unlikely but should be considered. should that be considered problem? should we allow - or force - using monotonic time?
_0, _1, _2 bagfile name suffixes are instead replaced with timestamps.
Implementation Notes / Suggestions
The base feature should be a relatively easy addition in the SequentialWriter, probably using std::strftime (which suggests to me that we could allow user to provide the format string without much issue).
The edge cases may end up introducing complications depending what we decide.
Testing Notes / Suggestions
The text was updated successfully, but these errors were encountered:
Description
Name individual bagfiles with a timestamp of their start time, rather than an increasing integer index serial number.
I think most of the time, we don't care which number split a file is, but rather are interested in what time period it represents.
An illustration:
Should create this structure
Open questions:
Related Issues
Part of #1915
Discussed in #1910
Completion Criteria
_0, _1, _2 bagfile name suffixes are instead replaced with timestamps.
Implementation Notes / Suggestions
The base feature should be a relatively easy addition in the
SequentialWriter
, probably usingstd::strftime
(which suggests to me that we could allow user to provide the format string without much issue).The edge cases may end up introducing complications depending what we decide.
Testing Notes / Suggestions
The text was updated successfully, but these errors were encountered: