Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping multi-RMW tests defined in test_communication for rmw_zenoh #559

Open
Yadunund opened this issue Feb 24, 2025 · 0 comments
Open

Comments

@Yadunund
Copy link
Member

Yadunund commented Feb 24, 2025

As we look to run CI with rmw_zenoh, a non-DDS based middleware which would not support any cross-vendor tests, we'll need a way to skip running multi-RMW tests part of test_communication. At present system_tests/test_communication sets SKIP_MULTI_RMW_TESTS to OFF by default while explictly excluding certain cross-vendor tests for certain DDS middleware combinations.

If we add rmw_zenoh to the ros2.repos file and run CI, we can expect failures across all cros-vendor tests.

One "easy" way to resolve this is to add further exceptions to the CMakeLists.txt linked above for rmw_zenoh.

Another suggestion from @cottsay is to be able to infer "groups" of RMWs that are expected to be compatible on a per-test basis.

Related to #429.

@Yadunund Yadunund changed the title Skipping multi-RMW tests for rmw_zenoh defined in test_communication Skipping multi-RMW tests defined in test_communication for rmw_zenoh Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant