Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional config for roundcube #267

Open
freman opened this issue Oct 22, 2024 · 1 comment
Open

Optional config for roundcube #267

freman opened this issue Oct 22, 2024 · 1 comment
Labels
needs-feedback Waiting for feedback from reporter

Comments

@freman
Copy link
Contributor

freman commented Oct 22, 2024

Hey, so at the moment the only way to tweak roundcube config (say to add config for a plugin) is to replace a config file, I'd like to propose the following change

mkdir config/config.inc.d/
mv config/config.docker.inc.php config/config.inc.d/

replace the include line from config.inc.d to

foreach (glob("config.inc.d/*.php") as $filename)
{
    include $filename;
}

We could mount various configs into that dir.

alternatively just have config.docker.inc.php check for a user include mounted into that dir and include that...

@thomascube
Copy link
Member

For additional config files we have the /var/roundcube/config volume which is loaded pretty much the same way you propose here except that the for loop is done in the docker-entrypoint and not in PHP:
https://github.com/roundcube/roundcubemail-docker/blob/master/apache/docker-entrypoint.sh#L153-L156

I don't see the benefit of the way you propose to what we already have. Please clarify if I seem to miss something here.

@pabzm pabzm added the needs-feedback Waiting for feedback from reporter label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Waiting for feedback from reporter
Projects
None yet
Development

No branches or pull requests

3 participants