Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to roundcubemail not published on roundcubemail-docker #8

Closed
adlerweb opened this issue Apr 12, 2018 · 15 comments
Closed

Updates to roundcubemail not published on roundcubemail-docker #8

adlerweb opened this issue Apr 12, 2018 · 15 comments

Comments

@adlerweb
Copy link

This docker repository as well as the official image on hub.docker.com are several versions behind and include known security vulnerabilities.

Changing ENV ROUNDCUBEMAIL_VERSION seems to work, maybe this could be automated to be run and posted as soon as there is a new push on roundcubemail/releases as suggested in #1.

@thomascube
Copy link
Member

Pushed latest version to Docker hub: https://hub.docker.com/r/roundcube/roundcubemail/tags/

@thomascube
Copy link
Member

Will configure automated builds on Docker hub once our Docker images are considered "final". We're still in the process of finding the right way to deliver Roundcube via Docker. There are many ways and opinions how to do it.

@J0WI
Copy link
Contributor

J0WI commented Apr 19, 2018

The FPM variant is not yet published on Dockerhub at all.

@adlerweb
Copy link
Author

adlerweb commented May 7, 2018

Maybe you should add a note over on Docker hub to clarify these are not final for the meantime

@compuguy
Copy link

compuguy commented Oct 19, 2018

Wondering when the docker hub builds will be updated, they just fixed another issue with this image in #27.

@J0WI
Copy link
Contributor

J0WI commented Oct 19, 2018

There are also some outstanding security updates for the underlying image: #32

@J0WI
Copy link
Contributor

J0WI commented Jan 23, 2019

@thomascube the image lacks many security patches from Debian and PHP. Please trigger rebuilds.

@J0WI
Copy link
Contributor

J0WI commented Feb 1, 2019

Or maybe @alecpl has time to trigger a rebuild...

@thomascube
Copy link
Member

New images for Roundcube 1.3.8 have been pushed.

@madmath03
Copy link
Collaborator

Based on @thomascube comment in #56 (comment), autobuilds have been enabled so this can be closed.

@thomascube
Copy link
Member

The ticket requests that "Updates to roundcubemail" (I assume new releases) are automatically propagated to this repo (-> updating ROUNDCUBEMAIL_VERSION) which shall then trigger automated builds. I think we're not there yet.

@madmath03
Copy link
Collaborator

Indeed, if this is what was intended then we're not there yet.
This would actually require an external service to be triggered on each new rouncubemail release.

By the way, even if it would not solve this completely, the PR #55 would greatly help :

  • you would just need to execute the update.sh script, which would update all the dockerfiles with the latest release, and then push the changes
  • the automated docker builds would catch the github commit and build the new images for the existing tags and you would just need to add the new tag

Even if it's not 100% automatic, it would only be a matter of minutes to push new releases.

What do you think ?

@J0WI
Copy link
Contributor

J0WI commented Jul 24, 2019

Or you just solve #31 and let the @docker-library-bot take care of updates.

@thomascube
Copy link
Member

I agree that PR #55 would greatly help here. However, this still doesn't work on my Mac with Bash 5.0 :-(

@J0WI
Copy link
Contributor

J0WI commented Jul 25, 2019

You also need curl. What error do you get with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants