Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pgadmin4] namespace name need to quote to support numeric named namespace #241

Open
miteshpatelfxt opened this issue Feb 1, 2024 · 0 comments

Comments

@miteshpatelfxt
Copy link

Describe the bug
A clear and concise description of what the bug is.

Version of Helm and Kubernetes:

Which chart:
pgadmin4

What happened:
we use numeric namespace name
getting this error.

json: cannot unmarshal number into Go struct field ObjectMeta.metadata.namespace of type string.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:
Thank you.
I tested it locally, just need to add "| quote" in the pgadmin.namespaceName helper function

{{/*
Create the name of the namespace
*/}}
{{- define "pgadmin.namespaceName" -}}
{{- default .Release.Namespace .Values.namespace | quote }}
{{- end }}

@miteshpatelfxt miteshpatelfxt changed the title pgadmin4 issue title pgadmin4 - namespace name need to quote to support numeric named namespace Feb 1, 2024
@miteshpatelfxt miteshpatelfxt changed the title pgadmin4 - namespace name need to quote to support numeric named namespace [pgadmin4] namespace name need to quote to support numeric named namespace Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant