Page reload locks object in admin

[andreynovikov]

• django-lock-tokens version: 0.2.3
• Django version: 1.11
• Python version: 3.5
• Operating System: Debian

Description

I use LockableModelAdmin to provide basic locking of a change form. The issue is that when I press page reload the object gets locked. (In fact I have custom popup actions that reload the page but simple manual reload has the same effect). Tested in Chrome, can test in Firefox later.

Have you any ideas how to overcome this issue?

[andreynovikov]

Have tested it in Firefox, reload does not lock the page but there is another strange issue: when I leave change form via some link in admin nothing visually happens, and the change form page becomes "frozen" (do not respond to any clicks on it) until I press reload.

[rparent]

Hello @andreynovikov

From what I understand, you have overriden the default change form template to add some custom actions on the client side.

You must be aware that the default change form template for LockableModelAdmin has a javascript event listener that unlocks token before leaving or reloading the page (see here).
Make sure you include the handle_lock template tag to your custom template to guarantee this behaviour, otherwise the object will not be unlocked unless you save it.

Also, it can happen that when refreshing, the delete request made on the client side finishes after the new change_view for refresh gets called. So in this case the previous token is deleted just right after refreshing. If you refresh once again, the object will be correctly unlocked. That's not perfect, but it is hard to fix easily right now...

About you Firefox bug, I can't reproduce it. I suspect there might be some issues / conflicts with your custom js code. Can you give a bit more information ?

[andreynovikov]

I have this code but as I see in the server logs indeed DELETE request comes after GET.